public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Richard Weinberger <richard@nod.at>,
	linux-kernel@vger.kernel.org,
	user-mode-linux-devel@lists.sourceforge.net,
	Al Viro <viro@ftp.linux.org.uk>
Subject: Re: [PATCH 8/9] um: fix strrchr problems
Date: Mon, 29 Aug 2011 23:11:10 +0100	[thread overview]
Message-ID: <20110829221110.GO2203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20110829142705.5be82d7c.akpm@linux-foundation.org>

On Mon, Aug 29, 2011 at 02:27:05PM -0700, Andrew Morton wrote:

> z:/usr/src/linux-3.1-rc4> grep -r kernel_strrchr .       
> z:/usr/src/linux-3.1-rc4> 
> 
> ok, I give up.  How does this work?

You are grepping for the wrong thing ;-)  It works the same way defines
next to it do - both the kernel and libc define functions with the
same name (doing the same thing) and we get problems when linking.

See the comment right before it:

# -Dvmap=kernel_vmap prevents anything from referencing the libpcap.o symbol so
# named - it's a common symbol in libpcap, so we get a binary which crashes.
#
# Same things for in6addr_loopback and mktime - found in libc. For these two we
# only get link-time error, luckily.
#
# These apply to USER_CFLAGS to.


  parent reply	other threads:[~2011-08-29 22:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-29 16:13 UML fixes for 3.1-rcX (2nd try) Richard Weinberger
2011-08-29 16:13 ` [PATCH 1/9] um: disable CMPXCHG_DOUBLE as it breaks UML build Richard Weinberger
2011-08-29 17:35   ` Christoph Lameter
2011-08-29 16:13 ` [PATCH 2/9] um: drivers/xterm.c: fix a file descriptor leak Richard Weinberger
2011-08-29 16:13 ` [PATCH 3/9] um: Save FPU registers between task switches Richard Weinberger
2011-08-29 16:13 ` [PATCH 4/9] um: fix oopsable race in line_close() Richard Weinberger
2011-08-29 16:13 ` [PATCH 5/9] um: winch_interrupt() can happen inside of free_winch() Richard Weinberger
2011-08-29 16:13 ` [PATCH 6/9] um: fix free_winch() mess Richard Weinberger
2011-08-29 16:13 ` [PATCH 7/9] um: PTRACE_[GS]ETFPXREGS had been wired on the wrong subarch Richard Weinberger
2011-08-29 16:13 ` [PATCH 8/9] um: fix strrchr problems Richard Weinberger
2011-08-29 21:27   ` Andrew Morton
2011-08-29 21:38     ` Richard Weinberger
2011-08-29 22:12       ` Al Viro
2011-08-29 22:15         ` Richard Weinberger
2011-08-29 22:19           ` Al Viro
2011-08-29 22:25             ` Richard Weinberger
2011-08-29 23:28               ` [uml-devel] " Boaz Harrosh
2011-08-30  0:23               ` Al Viro
2011-08-30  2:48                 ` Al Viro
2011-08-30 10:32                   ` Richard Weinberger
2011-08-30 12:48                     ` Al Viro
2011-08-29 22:39             ` Arnaud Lacombe
2011-08-29 22:11     ` Al Viro [this message]
2011-08-30  3:41     ` [uml-devel] " Jeff Dike
2011-08-29 16:13 ` [PATCH 9/9] um: clean arch_ptrace() up a bit Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110829221110.GO2203@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@nod.at \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox