* [PATCH] um: fix strrchr problems
@ 2011-08-30 11:04 Richard Weinberger
2011-08-30 12:04 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: Richard Weinberger @ 2011-08-30 11:04 UTC (permalink / raw)
To: akpm
Cc: linux-kernel, user-mode-linux-devel, Al Viro, jdike, Al Viro,
Richard Weinberger
From: Al Viro <viro@ftp.linux.org.uk>
[richard@nod.at:
Fixes:
/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libc.a(strrchr.o): In function `rindex':
(.text+0x0): multiple definition of `strrchr'
If both STATIC_LINK and UML_NET_VDE are set to "y" libc's strstr
may clash with the kernel implementation.
This workaround comes originally from Jeff Dike:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=494995#35
]
CC: jdike@addtoit.com
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
arch/um/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/um/Makefile b/arch/um/Makefile
index fab8121..c0f712c 100644
--- a/arch/um/Makefile
+++ b/arch/um/Makefile
@@ -41,7 +41,7 @@ KBUILD_CPPFLAGS += -I$(srctree)/$(ARCH_DIR)/sys-$(SUBARCH)
KBUILD_CFLAGS += $(CFLAGS) $(CFLAGS-y) -D__arch_um__ -DSUBARCH=\"$(SUBARCH)\" \
$(ARCH_INCLUDE) $(MODE_INCLUDE) -Dvmap=kernel_vmap \
-Din6addr_loopback=kernel_in6addr_loopback \
- -Din6addr_any=kernel_in6addr_any
+ -Din6addr_any=kernel_in6addr_any -Dstrrchr=kernel_strrchr
KBUILD_AFLAGS += $(ARCH_INCLUDE)
--
1.7.6.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] um: fix strrchr problems
2011-08-30 11:04 [PATCH] um: fix strrchr problems Richard Weinberger
@ 2011-08-30 12:04 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2011-08-30 12:04 UTC (permalink / raw)
To: Richard Weinberger
Cc: akpm, linux-kernel, user-mode-linux-devel, Al Viro, jdike
On Tue, Aug 30, 2011 at 01:04:04PM +0200, Richard Weinberger wrote:
> From: Al Viro <viro@ftp.linux.org.uk>
>
> [richard@nod.at:
> Fixes:
> /usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libc.a(strrchr.o): In function `rindex':
> (.text+0x0): multiple definition of `strrchr'
>
> If both STATIC_LINK and UML_NET_VDE are set to "y" libc's strstr
^^^^^^
strrchr...
> may clash with the kernel implementation.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-30 12:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-30 11:04 [PATCH] um: fix strrchr problems Richard Weinberger
2011-08-30 12:04 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox