RE: [PATCH 44/46] Staging: hv: vmbus: Fix checkpatch warnings in connection.c

KY Srinivasan
2011-08-30T17:03:59Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1179 bytes --]

> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: Sunday, August 28, 2011 2:57 AM
> To: KY Srinivasan
> Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang
> Subject: Re: [PATCH 44/46] Staging: hv: vmbus: Fix checkpatch warnings in
> connection.c
>
> On Sat, 2011-08-27 at 11:31 -0700, K. Y. Srinivasan wrote:
> > Fix checkpatch warnings in connection.c.
> []
> > diff --git a/drivers/staging/hv/connection.c b/drivers/staging/hv/connection.c
> []
> > @@ -220,11 +220,11 @@ static void process_chn_event(u32 relid)
> > channel = relid2channel(relid);
> >
> > spin_lock_irqsave(&channel->inbound_lock, flags);
> > - if (channel && (channel->onchannel_callback != NULL)) {
> > + if (channel && (channel->onchannel_callback != NULL))
>
> Useless test for channel or bad placement for spin_lock.
> channel has already been dereferenced by the spin_lock.
>
>
Thanks Joe. I will fix this up.

Regards,

K. Y
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥