Re: [v2 2/4] platform: (TS-5500) add GPIO support

Vivien Didelot
2011-08-30T21:12:11Z

On Mon, 29 Aug 2011 23:11:33 +0100,
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:

> On Fri, Aug 26, 2011 at 07:40:25PM -0400, Vivien Didelot wrote:
> > + bitno = line_to_bit_map[offset];
> > +
> > + mutex_lock(&drvdata->gpio_lock);
> > + byte = inb(ioaddr);
> > + mutex_unlock(&drvdata->gpio_lock);
>
> Do you really need the lock to do a read?

Thanks for the explanation. I removed the mutex lock here as there's no
critical section except for the inb() call in this function.

Vivien.