Re: [v2 3/4] platform: (TS-5500) add LED support

Ingo Molnar
2011-11-16T05:43:52Z

* Ingo Molnar <mingo@elte.hu> wrote:

> * Vivien Didelot <vivien.didelot@savoirfairelinux.com> wrote:
>
> > On Wed, 12 Oct 2011 17:34:15 +0200,
> > Ingo Molnar <mingo@elte.hu> wrote:
> >
> > >
> > > * Vivien Didelot <vivien.didelot@savoirfairelinux.com> wrote:
> > >
> > > > From: Jonas Fonseca <jonas.fonseca@savoirfairelinux.com>
> > > >
> > > >
> > > > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> > >
> > > That's not a valid signoff sequence. Did you intend this to be:
> > >
> > > From: Jonas Fonseca <jonas.fonseca@savoirfairelinux.com>
> > >
> > > Signed-off-by: Jonas Fonseca <jonas.fonseca@savoirfairelinux.com>
> > > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> > >
> > > ?
> > >
> > > Thanks,
> > >
> > > Ingo
> >
> > Yes, this should be signed off by Jonas Fonseca as well. This will
> > be updated in the next patches set.
>
> I've already applied the current patches with the SOBs fixed (the
> merge window is getting close), to the tip:x86/platform branch.
>
> Please send any fixes as add-on delta patches against tip:master:
>
> git://tesla.tglx.de/git/linux-2.6-tip.git

(tap, tap, is this thing on?)

Should i drop these commits:

32a85aa727ce: x86/platform: Add TS-5500 ADC support
3a338d79aa95: x86/platform: Add TS-5500 LED support
2437b498abac: x86/platform: Add TS-5500 GPIO support
37f9a16c166c: x86/platform: Add TS-5500 base support

from tip:x86/platform?

Had this (probably trivial) build failure been fixed when i reported
it over a month ago then these commits could have been included in
the v3.2 upstream kernel - now they will probably have to be delayed
to v3.3.

Thanks,

Ingo