Re: [v2 2/4] platform: (TS-5500) add GPIO support

H. Peter Anvin
2011-08-30T05:38:06Z

On 08/29/2011 03:11 PM, Mark Brown wrote:
> On Fri, Aug 26, 2011 at 07:40:25PM -0400, Vivien Didelot wrote:
>
>> arch/x86/platform/ts5500/ts5500_gpio.c | 421 ++++++++++++++++++++++++++++++++
>> arch/x86/platform/ts5500/ts5500_gpio.h | 60 +++++
>
> New GPIO drivers should really go under drivers/gpiolib and be called
> gpio-foo.c.
>

Should they? It seems a lot more reasonable to have them collected by
platform than by type of device (GPIO), *unless* they are shared.

-hpa