Re: [v2 2/4] platform: (TS-5500) add GPIO support

Vivien Didelot
2011-10-15T14:38:27Z

On Fri, 14 Oct 2011 08:14:27 +0200,
Ingo Molnar <mingo@elte.hu> wrote:

>
> * Ingo Molnar <mingo@elte.hu> wrote:
>
> >
> > * Vivien Didelot <vivien.didelot@savoirfairelinux.com> wrote:
> >
> > > From: Jerome Oufella <jerome.oufella@savoirfairelinux.com>
> > >
> > > Signed-off-by: Vivien Didelot
> > > <vivien.didelot@savoirfairelinux.com>
> >
> > Same question as for the other patch, was this intended to be:
> >
> > From: Jerome Oufella <jerome.oufella@savoirfairelinux.com>
> >
> > Signed-off-by: Jerome Oufella
> > <jerome.oufella@savoirfairelinux.com> Signed-off-by: Vivien Didelot
> > <vivien.didelot@savoirfairelinux.com>
> >
> > ?
>
> Ping? These patches cannot be advanced without a proper SOB sequence.

Sorry for the late reply.

You're right, this should be:
Signed-off-by: Jerome Oufella <jerome.oufella@savoirfairelinux.com>
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

>
> Also, with the attached config i get this build failure:
>
> arch/x86/built-in.o: In function `ts5500_adc_probe':
> ts5500_adc.c:(.devinit.text+0x1e1): undefined reference to
> `hwmon_device_register' make: *** [.tmp_vmlinux1] Error 1
>
> Which kind of build failure is typically some sort of
> modular/built-in corner case combination:
>
> CONFIG_HWMON=m
> CONFIG_HWMON_VID=m
> # CONFIG_HWMON_DEBUG_CHIP is not set
> CONFIG_THERMAL_HWMON=y
> CONFIG_TS5500=y
> # CONFIG_TS5500_GPIO is not set
> CONFIG_TS5500_LED=y
> CONFIG_TS5500_ADC=y
> CONFIG_LEDS_GPIO=m
> CONFIG_LEDS_TRIGGER_GPIO=m
>
> And is generally fixed by cleaner/better Kconfig dependencies.
>
> Thanks,
>
> Ingo

Thanks for the comment, there's obviously a dependence issue here. This
will be fixed soon.

Thanks,

Vivien