Re: [v2 2/4] platform: (TS-5500) add GPIO support

Vivien Didelot
2011-08-30T14:50:07Z

On Tue, 30 Aug 2011 12:00:20 +0100,
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:

> On Mon, Aug 29, 2011 at 10:36:32PM -0700, H. Peter Anvin wrote:
> > On 08/29/2011 03:11 PM, Mark Brown wrote:
>
> > > New GPIO drivers should really go under drivers/gpiolib and be
> > > called gpio-foo.c.
>
> > Should they? It seems a lot more reasonable to have them collected
> > by platform than by type of device (GPIO), *unless* they are shared.

Grouping every driver for this platform was one of the main comments of
my first RFC set of patches. And indeed, the GPIO driver is really
specific to this platform, so it won't be shared.

Vivien.
>
> There was some discussion of this, mostly for ARM, the general
> conclusion being that sharing the code improves visibility of things
> for the subsystem maintainer, ensures that the code gets reviewed (and
> updated if things change) by subsystem experts and makes it more
> likely that where there are things that can be shared someone will
> notice.