Re: [patch v2 19/35] Hexagon: Add ptrace support

Arnd Bergmann
2011-08-31T14:07:46Z

On Tuesday 30 August 2011, Richard Kuo wrote:
> +
> + switch (request) {
> + case PTRACE_POKETEXT: /* write the word at location addr. */
> + case PTRACE_POKEDATA:
> + return generic_ptrace_pokedata(child, addr, data);
> + case PTRACE_POKEUSR: /* write register specified by addr. */
> + return ptrace_pokeusr(child, addr, data);
> + case PTRACE_GETREGS:
> + return copy_regset_to_user(child, &hexagon_user_view,
> + REGSET_GPR, 0,
> + sizeof(struct user_regs_struct),
> + udata);
> + case PTRACE_SETREGS:
> + return copy_regset_from_user(child, &hexagon_user_view,
> + REGSET_GPR, 0,
> + sizeof(struct user_regs_struct),
> + udata);

I don't remember if I commented on this or if it was for the c6x architecture
submission. Anyway, I think you should let all of this be handled through
the generic ptrace support like openrisc does.

Arnd