Re: [PATCH v3] memcg: add memory.vmscan_stat

Ying Han
2011-08-13T01:04:58Z

On Tue, Aug 9, 2011 at 1:01 AM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:
>
> On Tue, 9 Aug 2011 10:01:59 +0200
> Johannes Weiner <jweiner@redhat.com> wrote:
>
> > On Tue, Aug 09, 2011 at 08:33:45AM +0900, KAMEZAWA Hiroyuki wrote:
> > > On Mon, 8 Aug 2011 14:43:33 +0200
> > > Johannes Weiner <jweiner@redhat.com> wrote:
> > > > On a non-technical note: as Ying Han and I were the other two people
> > > > working on reclaim and statistics, it really irks me that neither of
> > > > us were CCd on this.  Especially on such a controversial change.
> > >
> > > I always drop CC if no reply/review comes.
> >
> > There is always the possibility that a single mail in an otherwise
> > unrelated patch series is overlooked (especially while on vacation ;).
> > Getting CCd on revisions and -mm inclusion is a really nice reminder.
> >
> > Unless there is a really good reason not to (is there ever?), could
> > you please keep CCs?
> >
>
> Ok, if you want, I'll CC always.
> I myself just don't like to get 3 copies of mails when I don't have
> much interests ;)
>
> Thanks,
> -Kame

Hi Kame, Johannes,

Sorry for getting into this thread late and here are some comments:

There are few patches that we've been working on which could change
the memcg reclaim path quite bit. I wonder if they have chance to be
merged later, this patch might need to be adjusted accordingly as
well. If the ABI needs to be changed, that would be hard.

There is a patch Andrew (abrestic@) has been testing which adds the
same memory.vmscan_stat, but based on some page reclaim patches.
(Mainly the memcg-aware global reclaim from Johannes ). And it does
adjust to the hierarchical reclaim change as Johannes mentioned.

So, may I suggest us to hold on this patch for now? while the other
page reclaim changes being settled, we can then add it in.

Thanks

--Ying

>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email: email@kvack.org