Re: [patch v2 17/35] Hexagon: Add interrupts

Linas Vepstas (Code Aurora)
2011-08-31T16:16:29Z

On Wed, Aug 31, 2011 at 03:50:23PM +0200, Arnd Bergmann wrote:
> > +/*
> > + * XXX TODO FIXME this should be pulled from a platform file!
> > + * Must define NR_IRQS before including <asm-generic/irq.h>
> > + * 64 == the two SIRC's, 176 == the two gpio's
> > + */
> > +#define NR_IRQS (HEXAGON_CPUINTS + 64 + 176)
>
> I disagree with that comment: NR_IRQS is a constant and should
> not be platform specific. There should be no compile-time settings
> that are strictly specific to one platform, otherwise you are not

OK. The interrupt handling on hexagon really is under construction:
not only do we need to finish support for the device tree, but there's
also a bunch of nasty ugliness in how the second & third-level
interrupt cntrollers are handled. Some of the difficulties are due
the fact that we are re-cycling some of the msm drivers in the
arm platform directories. The hexagon and the arm are on the same
chip, and see the same controllers, more or less, just with
different address ranges and sometimes with different permissions,
different pin numberings, etc.

Some of these patches are missing Signed-off-by-me lines, I take
full responsibility for all triple-X's that are lingering.

-- Linas

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.