From: Frederic Weisbecker <fweisbec@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 1/2] nohz: Drop useless call in tick_nohz_start_idle()
Date: Thu, 1 Sep 2011 14:31:30 +0200 [thread overview]
Message-ID: <20110901123126.GA24650@somewhere.redhat.com> (raw)
In-Reply-To: <1311274177-23891-1-git-send-email-fweisbec@gmail.com>
Forget these patches. Peterz found that the 2nd one is buggy and
I need to refine the others changelog.
Thnaks.
On Thu, Jul 21, 2011 at 08:49:36PM +0200, Frederic Weisbecker wrote:
> The call to update_ts_time_stats() there is useless. All
> we need is to save the idle entry_time.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> ---
> kernel/time/tick-sched.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> index d5097c4..58e1a96 100644
> --- a/kernel/time/tick-sched.c
> +++ b/kernel/time/tick-sched.c
> @@ -185,9 +185,6 @@ static ktime_t tick_nohz_start_idle(int cpu, struct tick_sched *ts)
> ktime_t now;
>
> now = ktime_get();
> -
> - update_ts_time_stats(cpu, ts, now, NULL);
> -
> ts->idle_entrytime = now;
> ts->idle_active = 1;
> sched_clock_idle_sleep_event();
> --
> 1.7.5.4
>
prev parent reply other threads:[~2011-09-01 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 18:49 [PATCH 1/2] nohz: Drop useless call in tick_nohz_start_idle() Frederic Weisbecker
2011-07-21 18:49 ` [PATCH 2/2] nohz: Drop ts->idle_active Frederic Weisbecker
2011-07-25 21:14 ` [PATCH 3/2] nohz: Drop useless ts->inidle check before rearming the tick Frederic Weisbecker
2011-08-23 16:50 ` [PATCH 1/2] nohz: Drop useless call in tick_nohz_start_idle() Frederic Weisbecker
2011-09-01 12:31 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110901123126.GA24650@somewhere.redhat.com \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox