From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: Rik van Riel <riel@redhat.com>,
Randy Dunlap <rdunlap@xenotime.net>,
Satoru Moriya <smoriya@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
lwoodman@redhat.com, Seiji Aguchi <saguchi@redhat.com>,
hughd@google.com, hannes@cmpxchg.org
Subject: Re: [PATCH -v2 -mm] add extra free kbytes tunable
Date: Thu, 1 Sep 2011 15:16:50 -0700 [thread overview]
Message-ID: <20110901151650.0a82716b.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1109011501260.22550@chino.kir.corp.google.com>
On Thu, 1 Sep 2011 15:08:00 -0700 (PDT)
David Rientjes <rientjes@google.com> wrote:
> On Thu, 1 Sep 2011, Andrew Morton wrote:
>
> > > Add a userspace visible knob
> >
> > argh. Fear and hostility at new knobs which need to be maintained for
> > ever, even if the underlying implementation changes.
> >
>
> Do we really need to maintain tunables that lose their purpose either
> because the implementation changes or is patched to fix the issue that the
> tunable was intended to address without requiring it?
>
> Are there really userspace tools written to not be able to handle -ENOENT
> when one of these gets removed?
I don't know, and neither does anyone else. So we need to be cautious.
Like putting a warning printk in there and waiting several years.
And it's not just a matter of handling ENOENT. The user modified this
tunable for a *reason*. They were expecting some behaviour change in
the kernel. If we remove the tunable, we take that behaviour change
away from them. So by adding this tunable, we constrain future
implementations by requiring those implementations to automatically do
whatever the user was previously doing manually. And we don't reliably
know *why* each user altered that tunable. It's a horrid mess.
next prev parent reply other threads:[~2011-09-01 22:17 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 14:52 [PATCH -mm] add extra free kbytes tunable Rik van Riel
2011-09-01 17:06 ` Randy Dunlap
2011-09-01 19:26 ` [PATCH -v2 " Rik van Riel
2011-09-01 21:58 ` Andrew Morton
2011-09-01 22:08 ` David Rientjes
2011-09-01 22:16 ` Andrew Morton [this message]
2011-09-02 16:31 ` Satoru Moriya
2011-10-13 7:33 ` Minchan Kim
2011-10-13 8:09 ` KAMEZAWA Hiroyuki
[not found] ` <E1FA588BC672D846BDBB452FCA1E308C2389B4@USINDEVS02.corp.hds.com>
2011-09-15 3:33 ` Satoru Moriya
2011-09-01 22:09 ` Andrew Morton
2011-09-02 16:26 ` [PATCH -mm] fixes & cleanups for "add extra free kbytes tunable" Rik van Riel
2011-09-30 21:43 ` [PATCH -v2 -mm] add extra free kbytes tunable Johannes Weiner
2011-10-08 3:08 ` David Rientjes
2011-10-10 22:37 ` Andrew Morton
2011-10-11 19:32 ` Satoru Moriya
2011-10-11 19:54 ` Andrew Morton
2011-10-11 20:23 ` Satoru Moriya
2011-10-11 20:54 ` Andrew Morton
2011-10-12 13:09 ` Rik van Riel
2011-10-12 19:20 ` Andrew Morton
2011-10-12 19:58 ` Rik van Riel
2011-10-12 20:26 ` David Rientjes
2011-10-21 23:48 ` Satoru Moriya
2011-10-23 21:22 ` David Rientjes
2011-10-25 2:04 ` Satoru Moriya
2011-10-25 21:50 ` David Rientjes
2011-10-26 18:59 ` Satoru Moriya
2011-10-12 21:08 ` Satoru Moriya
2011-10-12 22:41 ` David Rientjes
2011-10-12 23:52 ` Satoru Moriya
2011-10-13 0:01 ` David Rientjes
2011-10-13 5:35 ` KAMEZAWA Hiroyuki
2011-10-13 20:55 ` David Rientjes
2011-10-14 22:16 ` Satoru Moriya
2011-10-14 22:46 ` David Rientjes
2011-10-14 5:32 ` Satoru Moriya
2011-10-14 5:06 ` Satoru Moriya
2011-10-11 23:22 ` David Rientjes
2011-10-13 16:54 ` Satoru Moriya
2011-10-13 20:48 ` David Rientjes
2011-10-13 21:11 ` Rik van Riel
2011-10-13 22:02 ` David Rientjes
2011-10-11 19:20 ` Satoru Moriya
2011-10-11 21:04 ` David Rientjes
2011-10-12 13:13 ` Rik van Riel
2011-10-12 20:21 ` David Rientjes
2011-10-13 4:13 ` Rik van Riel
2011-10-13 5:22 ` David Rientjes
2011-10-22 0:11 ` Satoru Moriya
-- strict thread matches above, loose matches on Subject: below --
2011-09-09 23:01 Satoru Moriya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110901151650.0a82716b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lwoodman@redhat.com \
--cc=rdunlap@xenotime.net \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=saguchi@redhat.com \
--cc=smoriya@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox