Re: Approaches to making io_submit not block

Dave Chinner
2011-09-01T03:39:09Z

On Wed, Aug 31, 2011 at 01:26:27AM -0400, Christoph Hellwig wrote:
> On Tue, Aug 30, 2011 at 02:51:01PM -0700, Daniel Ehrenberg wrote:
> > > Let filesystems handle this. ?I've actually prototyped it in XFS,
> > > based on some pending work from Dave but at this point it's still butt
> > > ugly.
> >
> > Great, would you be willing to let me see the draft code?
> >
> > Are you sure that there wouldn't be any benefit to having the code be
> > in the aio/dio levels in terms of making it easier for file
> > systems/reducing code duplication?
>
> I'll get it polished up and send it out for RFC once Dave sends out
> the updated allocation workqueue patch. With this he moves all
> allocator calls in XFS into a workqueue. My direct I/O patch uses that
> fact to use that workqueue for the allocator call and let the existing
> aio retry infrastructure retry the direct I/O operation one that
> workqueue has finished.

I thought you didn't like that code, Christoph. ;)

I'll resend it soon.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com