From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758045Ab1IAVYo (ORCPT ); Thu, 1 Sep 2011 17:24:44 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:38628 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758017Ab1IAVYn (ORCPT ); Thu, 1 Sep 2011 17:24:43 -0400 Date: Fri, 2 Sep 2011 00:24:13 +0300 From: "Maxin B. John" To: Amit Kucheria Cc: Jonathan Cameron , Greg Kroah-Hartman , Bryan Freed , Arnd Bergmann , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: iio: light: Fix compiler warning in tsl2563.c Message-ID: <20110901212413.GA3371@maxin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CC [M] drivers/staging/iio/light/tsl2563.o drivers/staging/iio/light/tsl2563.c: In function 'tsl2563_probe': drivers/staging/iio/light/tsl2563.c:736: warning: 'id' may be used uninitialized in this function Also fixes the tsl2563_read_id(). Signed-off-by: Maxin B. John --- diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c index f25243b..f8f787d 100644 --- a/drivers/staging/iio/light/tsl2563.c +++ b/drivers/staging/iio/light/tsl2563.c @@ -225,9 +225,9 @@ static int tsl2563_read_id(struct tsl2563_chip *chip, u8 *id) ret = i2c_smbus_read_byte_data(client, TSL2563_CMD | TSL2563_REG_ID); if (ret < 0) - return ret; + return -EIO; - return 0; + return ret; } /* @@ -697,7 +697,7 @@ static int __devinit tsl2563_probe(struct i2c_client *client, struct tsl2563_platform_data *pdata = client->dev.platform_data; int err = 0; int ret; - u8 id; + u8 id = 0; indio_dev = iio_allocate_device(sizeof(*chip)); if (!indio_dev) @@ -709,15 +709,17 @@ static int __devinit tsl2563_probe(struct i2c_client *client, chip->client = client; err = tsl2563_detect(chip); - if (err) { + if (err < 0) { dev_err(&client->dev, "device not found, error %d\n", -err); goto fail1; } err = tsl2563_read_id(chip, &id); - if (err) + if (err < 0) { + dev_err(&client->dev, "id reading failed, error %d\n", -err); goto fail1; - + } + id = err; mutex_init(&chip->lock); /* Default values used until userspace says otherwise */