From: Oleg Nesterov <oleg@redhat.com>
To: Earl Chew <echew@ixiacom.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"andi@firstfloor.org" <andi@firstfloor.org>
Subject: Re: [PATCH 1/1 v2]: coredump: use current->group_leader->comm instead of current->comm
Date: Fri, 2 Sep 2011 18:30:37 +0200 [thread overview]
Message-ID: <20110902163037.GA4808@redhat.com> (raw)
In-Reply-To: <4E5FD937.7050307@ixiacom.com>
On 09/01, Earl Chew wrote:
>
> > In your view, but there is a better way to do this - add a new case and
> > letter for the behaviour you want. That way you don't break anyone elses
> > defaults and expectation and people can set a corepattern dependant upon
> > the group leader.
>
> Ok.
>
>
> The patterns %n or %N are the same as %e and %E except that they
> use current->group_leader->comm instead of current->comm.
I simply do not know what is better. Alan has a point imho, "might
break stuff" is true.
OTOH, %p always reports tgid, not tid...
But in fact I do not understand the "Using current->group_leader->comm
makes the name of the core file more consistent" part. Why ?
> A core dump can be triggered from any task in a group,
Indeed. The important case is the private/synchronous signals like
SIGSEGV, you can see the name of the thread which triggered the crash.
> -static int cn_print_exe_file(struct core_name *cn)
> +static int cn_print_exe_file(struct core_name *cn, const char *comm)
> {
> struct file *exe_file;
> char *pathbuf, *path;
> @@ -1679,7 +1679,7 @@ static int cn_print_exe_file(struct core
> exe_file = get_mm_exe_file(current->mm);
> if (!exe_file) {
> char *commstart = cn->corename + cn->used;
> - ret = cn_printf(cn, "%s (path unknown)", current->comm);
> + ret = cn_printf(cn, "%s (path unknown)", comm);
Imho, this is overkill. This is only used if get_mm_exe_file() fails,
I don't think this deserves another option. And may be we can use
group_leader->comm, this is per-process thing anyway.
But I won't insist, I agree either way.
Oleg.
next prev parent reply other threads:[~2011-09-02 16:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 17:01 [ PATCH 1/1 ] coredump: use current->group_leader->comm instead of current->comm Earl Chew
2011-09-01 18:55 ` Alan Cox
2011-09-01 19:12 ` [PATCH 1/1 v2]: " Earl Chew
2011-09-02 16:30 ` Oleg Nesterov [this message]
2011-09-02 17:09 ` Earl Chew
2011-09-02 17:48 ` Oleg Nesterov
2011-09-02 23:05 ` Earl Chew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110902163037.GA4808@redhat.com \
--to=oleg@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=echew@ixiacom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox