From: Arnd Bergmann <arnd@arndb.de>
To: Stephen Warren <swarren@nvidia.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
Jean Delvare <khali@linux-fr.org>,
Ben Dooks <ben-linux@fluff.org>,
Russell King <linux@arm.linux.org.uk>,
Andrew Chew <AChew@nvidia.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH V2 1/4] i2c: Add irq_gpio field to struct i2c_client.
Date: Fri, 2 Sep 2011 18:05:27 +0200 [thread overview]
Message-ID: <201109021805.27569.arnd@arndb.de> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF04B327A55D@HQMAIL01.nvidia.com>
On Friday 02 September 2011, Stephen Warren wrote:
> The idea was specifically to replace the need to call irq_to_gpio(i2c->irq).
> If we did just rename it plain "gpio" and allow it to be used for anything,
> then that does indeed start looking more like device-specific platform data.
>
> I guess it sounds like consensus is to go that way. It does seem like that
> will end up creating a bunch more device-specific platform-data files though.
> I wonder if adding IORESOURCE_GPIO would make sense so this could be handled
> in a generic way without custom platform data types?
Interesting point. That's probably best for Grant to comment on, because
it depends on the long-term direction he wants to take with this.
I suppose that an IORESOURCE_GPIO makes a lot of sense if we expect
to keep having a flat system-wide gpio number space in the long run,
similar to irq numbers.
It would not fit well if we expect gpio numbers to be local to
a gpio controller, with no unique global identifier for them, similar
to how dma channels in the dma-engine subsystem are handled.
Arnd
next prev parent reply other threads:[~2011-09-02 16:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 16:52 [PATCH V2 1/4] i2c: Add irq_gpio field to struct i2c_client Stephen Warren
2011-09-01 16:52 ` [PATCH V2 2/4] staging:iio:magnetometer:ak8975 Don't use irq_to_gpio() Stephen Warren
2011-09-01 16:52 ` [PATCH V2 3/4] staging:iio:magnetometer:ak8975: Don't assume 0 is an invalid GPIO Stephen Warren
2011-09-02 8:51 ` Jonathan Cameron
2011-09-01 16:52 ` [PATCH V2 4/4] staging:iio:magnetometer:ak8975: Fix probe() error-handling Stephen Warren
2011-09-02 8:52 ` Jonathan Cameron
2011-09-01 16:52 ` [PATCH V2 1/4] i2c: Add irq_gpio field to struct i2c_client Stephen Warren
2011-09-01 17:37 ` Mark Brown
2011-09-02 8:48 ` Jonathan Cameron
2011-09-02 8:50 ` Jonathan Cameron
2011-09-02 15:30 ` Stephen Warren
2011-09-02 16:05 ` Arnd Bergmann [this message]
2011-09-07 19:07 ` Mark Brown
2011-09-01 16:52 ` [PATCH V2 2/4] staging:iio:magnetometer:ak8975 Don't use irq_to_gpio() Stephen Warren
2011-09-01 16:52 ` [PATCH V2 3/4] staging:iio:magnetometer:ak8975: Don't assume 0 is an invalid GPIO Stephen Warren
2011-09-01 16:52 ` [PATCH V2 4/4] staging:iio:magnetometer:ak8975: Fix probe() error-handling Stephen Warren
2011-09-01 18:30 ` [PATCH V2 1/4] i2c: Add irq_gpio field to struct i2c_client Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109021805.27569.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=AChew@nvidia.com \
--cc=ben-linux@fluff.org \
--cc=devel@driverdev.osuosl.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@suse.de \
--cc=jic23@cam.ac.uk \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox