From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751324Ab1IDENL (ORCPT ); Sun, 4 Sep 2011 00:13:11 -0400 Received: from mga03.intel.com ([143.182.124.21]:56168 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776Ab1IDENI (ORCPT ); Sun, 4 Sep 2011 00:13:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.68,326,1312182000"; d="scan'208";a="45389820" Date: Sun, 4 Sep 2011 12:13:05 +0800 From: Wu Fengguang To: Jan Kara Cc: Jens Axboe , LKML , Andrew Morton Subject: Re: [PATCH 1/2] mm: Cleanup clearing of BDI_pending bit in bdi_forker_thread() Message-ID: <20110904041305.GA25981@localhost> References: <1315004059-9844-1-git-send-email-jack@suse.cz> <1315004059-9844-2-git-send-email-jack@suse.cz> <20110904030442.GA16361@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110904030442.GA16361@localhost> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 04, 2011 at 11:04:42AM +0800, Wu Fengguang wrote: > On Sat, Sep 03, 2011 at 06:54:18AM +0800, Jan Kara wrote: > > bdi_forker_thread() clears BDI_pending bit at the end of the main loop. > > However clearing of this bit must not be done in some cases which is handled by > > calling 'continue' from switch statement. That's kind of unusual construct and > > without a good reason so change the function into more intuitive code flow. > > > > CC: Wu Fengguang > > CC: Andrew Morton > > Signed-off-by: Jan Kara > > It's pure code refactor. > > Reviewed-by: Wu Fengguang But I do suspect it will slightly increase the code size. What do you think? Thanks, Fengguang