From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org,
device-drivers-devel@blackfin.uclinux.org,
uclinux-dist-devel@blackfin.uclinux.org,
linux-kernel@vger.kernel.org,
Scott Jiang <scott.jiang.linux@gmail.com>
Subject: Re: [PATCH 2/3] ASoC: Allow codecs to provide their own regmap configuration
Date: Mon, 5 Sep 2011 10:45:04 -0700 [thread overview]
Message-ID: <20110905174503.GI3889@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4E650A3A.5050807@metafoo.de>
On Mon, Sep 05, 2011 at 07:43:22PM +0200, Lars-Peter Clausen wrote:
> I think it is useful, since we avoid duplicating that ugly switch statement
> and we also have to wrap regmap_write and regmap_read, duplicating that in each
> codec driver doesn't make sense.
When the CODEC drivers do the probe they should be setting the regmap up
in their individual bus probe functions so no switch statement.
next prev parent reply other threads:[~2011-09-05 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 13:18 [PATCH 1/3] regmap: Add support for device specific write and read flag masks Lars-Peter Clausen
2011-09-05 13:18 ` [PATCH 2/3] ASoC: Allow codecs to provide their own regmap configuration Lars-Peter Clausen
2011-09-05 17:29 ` Mark Brown
2011-09-05 17:43 ` Lars-Peter Clausen
2011-09-05 17:45 ` Mark Brown [this message]
2011-09-05 13:18 ` [PATCH 3/3] ASoC: ad193x: Setup regmap read and write flag masks for SPI Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110905174503.GI3889@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=scott.jiang.linux@gmail.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox