From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Huang Ying <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH -mm 2/4] llist, Define macro to check NMI safe cmpxchg
Date: Tue, 6 Sep 2011 06:50:26 -0400 [thread overview]
Message-ID: <20110906105026.GB21602@Krystal> (raw)
In-Reply-To: <1315290307-25145-2-git-send-email-ying.huang@intel.com>
* Huang Ying (ying.huang@intel.com) wrote:
> To make code cleaner and reduce code duplication. Thanks Peter
> Zijlstra for reminding.
>
> Signed-off-by: Huang Ying <ying.huang@intel.com>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> ---
> include/linux/llist.h | 22 ++++++++++------------
> 1 file changed, 10 insertions(+), 12 deletions(-)
>
> --- a/include/linux/llist.h
> +++ b/include/linux/llist.h
> @@ -70,6 +70,12 @@ struct llist_node {
> #define LLIST_HEAD_INIT(name) { NULL }
> #define LLIST_HEAD(name) struct llist_head name = LLIST_HEAD_INIT(name)
>
> +#ifdef CONFIG_ARCH_HAVE_NMI_SAFE_CMPXCHG
> +#define CHECK_NMI_SAFE_CMPXCHG()
Does it have to be in caps ? And can it be turned into a static inline
function ? I'm thinking about something close to might_sleep().
Thanks,
Mathieu
> +#else
> +#define CHECK_NMI_SAFE_CMPXCHG() BUG_ON(in_nmi())
> +#endif
> +
> /**
> * init_llist_head - initialize lock-less list head
> * @head: the head for your lock-less list
> @@ -147,9 +153,7 @@ static inline void llist_add(struct llis
> {
> struct llist_node *entry, *old_entry;
>
> -#ifndef CONFIG_ARCH_HAVE_NMI_SAFE_CMPXCHG
> - BUG_ON(in_nmi());
> -#endif
> + CHECK_NMI_SAFE_CMPXCHG();
>
> entry = head->first;
> do {
> @@ -171,9 +175,7 @@ static inline void llist_add_batch(struc
> {
> struct llist_node *entry, *old_entry;
>
> -#ifndef CONFIG_ARCH_HAVE_NMI_SAFE_CMPXCHG
> - BUG_ON(in_nmi());
> -#endif
> + CHECK_NMI_SAFE_CMPXCHG();
>
> entry = head->first;
> do {
> @@ -201,9 +203,7 @@ static inline struct llist_node *llist_d
> {
> struct llist_node *entry, *old_entry, *next;
>
> -#ifndef CONFIG_ARCH_HAVE_NMI_SAFE_CMPXCHG
> - BUG_ON(in_nmi());
> -#endif
> + CHECK_NMI_SAFE_CMPXCHG();
>
> entry = head->first;
> do {
> @@ -227,9 +227,7 @@ static inline struct llist_node *llist_d
> */
> static inline struct llist_node *llist_del_all(struct llist_head *head)
> {
> -#ifndef CONFIG_ARCH_HAVE_NMI_SAFE_CMPXCHG
> - BUG_ON(in_nmi());
> -#endif
> + CHECK_NMI_SAFE_CMPXCHG();
>
> return xchg(&head->first, NULL);
> }
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2011-09-06 10:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 6:25 [PATCH -mm 1/4] llist, Make all llist functions inline Huang Ying
2011-09-06 6:25 ` [PATCH -mm 2/4] llist, Define macro to check NMI safe cmpxchg Huang Ying
2011-09-06 10:50 ` Mathieu Desnoyers [this message]
2011-09-06 6:25 ` [PATCH -mm 3/4] llist, Move cpu_relax after cmpxchg Huang Ying
2011-09-06 10:52 ` Mathieu Desnoyers
2011-09-06 6:25 ` [PATCH -mm 4/4] irq_work, Use llist in irq_work Huang Ying
2011-09-06 10:57 ` Mathieu Desnoyers
2011-09-07 0:55 ` Huang Ying
2011-09-07 7:52 ` Peter Zijlstra
2011-09-06 10:47 ` [PATCH -mm 1/4] llist, Make all llist functions inline Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110906105026.GB21602@Krystal \
--to=mathieu.desnoyers@efficios.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox