From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Blockers on IIO usage of regmap.
Date: Tue, 6 Sep 2011 10:54:39 -0700 [thread overview]
Message-ID: <20110906175435.GA2924@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4E6600A8.4020101@cam.ac.uk>
On Tue, Sep 06, 2011 at 12:14:48PM +0100, Jonathan Cameron wrote:
> Just a quick heads up that the big blocker for
> us making more use of regmap is lack of default
> control of cs_change for spi buses. That leads to
Looking at what you've got here there's nothing interesting with /CS
here, it's all about the data formatting. Certainly you've not
mentioned anything odd with /CS in any of the code.
> TX Add0...Add7 XXXXXXXXXXX XXXXXXXXXXX XXXXXXXX
> RX XXXXXXXXXXX Da0.....Da7 Db0.....Db7 etc
This is the standard one that most things do so is already supported.
> TX Add0...Add7 XXXXXXXXXXX XXXXXXXXXXX XXXXXXXXXX
> RX XXXXXXXXXXX XXXXXXXXXXX Da0.....Da7 Db0....Db7
This is just inserting a delay so should be trivial to implement and
doesn't even look terribly SPI specific, just set a flag and it should
be fine. All we need here is someone to actually implement it. I guess
the delay will be OK for any read?
> TX Ada0...Ada7 Adb1...Adb7 Adc1...Adc7 etc
> RX XXXXXXXXXXX Da0.....Da7 Db0.....Db7 etc
This one is much more of a contortion to implement - it's pretty SPI
specific to stream the register addresses and it's really not what the
system is set up for. On the other hand if you can come up with a
taseful way to implement it then I don't see a problem.
> So basically we need some bus specific 'mode' hook somewhere.
> Given we have separate init functions for the buses could we
> add a struct regmap_spi_config to the parameter list?
Or just embed stuff into the main config structure at least for the
delay. Nothing there seems too outrageous, and the delay sounds like
something someone might do on other buses (the delay will be to allow
time for the ADCs or whatever to set up).
next prev parent reply other threads:[~2011-09-06 18:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 11:14 Blockers on IIO usage of regmap Jonathan Cameron
2011-09-06 11:32 ` Jonathan Cameron
2011-09-06 17:54 ` Mark Brown [this message]
2011-09-06 21:13 ` J.I. Cameron
2011-09-07 16:10 ` Jonathan Cameron
2011-09-07 16:19 ` [RFC PATCH 0/6] Using regmap with ADIS devices Jonathan Cameron
2011-09-07 16:19 ` [PATCH 1/6] SPI: add ability to say we want a cs change after every transfer Jonathan Cameron
2011-09-07 17:35 ` Mark Brown
2011-09-07 18:14 ` Jonathan Cameron
2011-09-07 18:12 ` Mark Brown
2011-09-07 18:28 ` Jonathan Cameron
2011-09-07 16:19 ` [PATCH 2/6] regmap: Add a magic bus type to handle quirks of analog devices ADIS sensors Jonathan Cameron
2011-09-07 17:47 ` Mark Brown
2011-09-07 18:26 ` Jonathan Cameron
2011-09-07 18:32 ` Mark Brown
2011-09-07 18:50 ` Jonathan Cameron
2011-09-07 18:44 ` Mark Brown
2011-09-07 19:14 ` Jonathan Cameron
2011-09-07 16:19 ` [PATCH 3/6] staging:iio:imu: adis16400 partial conversion to regmap Jonathan Cameron
2011-09-07 16:23 ` Jonathan Cameron
2011-09-07 16:19 ` [PATCH 4/6] regmap-spi-adi + staging:iio:imu:adis16400 halve register addresses Jonathan Cameron
2011-09-07 16:19 ` [PATCH 5/6] regmap-spi-adi generalize regmap_spi_read Jonathan Cameron
2011-09-07 16:19 ` [PATCH 6/6] staging:iio:imu:adis16400 make use of regmap bulk read capabilities Jonathan Cameron
2011-09-07 17:57 ` Blockers on IIO usage of regmap Mark Brown
2011-09-07 18:12 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110906175435.GA2924@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox