From: Grant Likely <grant.likely@secretlab.ca>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@elte.hu,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH 53/62] spi: irq: Remove IRQF_DISABLED
Date: Wed, 7 Sep 2011 10:37:02 -0700 [thread overview]
Message-ID: <20110907173702.GB9937@ponder.secretlab.ca> (raw)
In-Reply-To: <1315383059-3673-54-git-send-email-yong.zhang0@gmail.com>
On Wed, Sep 07, 2011 at 04:10:50PM +0800, Yong Zhang wrote:
> This flag is a NOOP and can be removed now.
>
> Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> drivers/spi/spi-bfin5xx.c | 2 +-
> drivers/spi/spi-coldfire-qspi.c | 2 +-
> drivers/spi/spi-ppc4xx.c | 2 +-
> drivers/spi/spi-sh-msiof.c | 2 +-
> drivers/spi/spi-sh.c | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/spi/spi-bfin5xx.c b/drivers/spi/spi-bfin5xx.c
> index b8d25f2..3b83ff8 100644
> --- a/drivers/spi/spi-bfin5xx.c
> +++ b/drivers/spi/spi-bfin5xx.c
> @@ -1098,7 +1098,7 @@ static int bfin_spi_setup(struct spi_device *spi)
>
> if (chip->pio_interrupt && !drv_data->irq_requested) {
> ret = request_irq(drv_data->spi_irq, bfin_spi_pio_irq_handler,
> - IRQF_DISABLED, "BFIN_SPI", drv_data);
> + 0, "BFIN_SPI", drv_data);
> if (ret) {
> dev_err(&spi->dev, "Unable to register spi IRQ\n");
> goto error;
> diff --git a/drivers/spi/spi-coldfire-qspi.c b/drivers/spi/spi-coldfire-qspi.c
> index ae2cd1c..7397c4d 100644
> --- a/drivers/spi/spi-coldfire-qspi.c
> +++ b/drivers/spi/spi-coldfire-qspi.c
> @@ -487,7 +487,7 @@ static int __devinit mcfqspi_probe(struct platform_device *pdev)
> goto fail2;
> }
>
> - status = request_irq(mcfqspi->irq, mcfqspi_irq_handler, IRQF_DISABLED,
> + status = request_irq(mcfqspi->irq, mcfqspi_irq_handler, 0,
> pdev->name, mcfqspi);
> if (status) {
> dev_dbg(&pdev->dev, "request_irq failed\n");
> diff --git a/drivers/spi/spi-ppc4xx.c b/drivers/spi/spi-ppc4xx.c
> index b267fd9..8ec43e0 100644
> --- a/drivers/spi/spi-ppc4xx.c
> +++ b/drivers/spi/spi-ppc4xx.c
> @@ -514,7 +514,7 @@ static int __init spi_ppc4xx_of_probe(struct platform_device *op)
> /* Request IRQ */
> hw->irqnum = irq_of_parse_and_map(np, 0);
> ret = request_irq(hw->irqnum, spi_ppc4xx_int,
> - IRQF_DISABLED, "spi_ppc4xx_of", (void *)hw);
> + 0, "spi_ppc4xx_of", (void *)hw);
> if (ret) {
> dev_err(dev, "unable to allocate interrupt\n");
> goto free_gpios;
> diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c
> index e00d94b..e38554f 100644
> --- a/drivers/spi/spi-sh-msiof.c
> +++ b/drivers/spi/spi-sh-msiof.c
> @@ -635,7 +635,7 @@ static int sh_msiof_spi_probe(struct platform_device *pdev)
> goto err2;
> }
>
> - ret = request_irq(i, sh_msiof_spi_irq, IRQF_DISABLED,
> + ret = request_irq(i, sh_msiof_spi_irq, 0,
> dev_name(&pdev->dev), p);
> if (ret) {
> dev_err(&pdev->dev, "unable to request irq\n");
> diff --git a/drivers/spi/spi-sh.c b/drivers/spi/spi-sh.c
> index 9eedd71..e0343d4 100644
> --- a/drivers/spi/spi-sh.c
> +++ b/drivers/spi/spi-sh.c
> @@ -484,7 +484,7 @@ static int __devinit spi_sh_probe(struct platform_device *pdev)
> goto error2;
> }
>
> - ret = request_irq(irq, spi_sh_irq, IRQF_DISABLED, "spi_sh", ss);
> + ret = request_irq(irq, spi_sh_irq, 0, "spi_sh", ss);
> if (ret < 0) {
> dev_err(&pdev->dev, "request_irq error\n");
> goto error3;
> --
> 1.7.4.1
>
next prev parent reply other threads:[~2011-09-08 4:58 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1315383059-3673-9-git-send-email-yong.zhang0@gmail.com>
[not found] ` <1315383059-3673-1-git-send-email-yong.zhang0@gmail.com>
2011-09-07 8:10 ` [PATCH 13/62] microblaze: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-07 8:10 ` [PATCH 17/62] powerpc: " Yong Zhang
2011-09-08 16:41 ` Arnd Bergmann
2011-09-07 8:10 ` [PATCH 18/62] score: " Yong Zhang
2011-09-07 8:10 ` [PATCH 24/62] xtensa: " Yong Zhang
2011-09-07 8:10 ` [PATCH 38/62] Input: " Yong Zhang
2011-09-07 23:21 ` Dmitry Torokhov
2011-09-07 8:10 ` [PATCH 39/62] ISDN: " Yong Zhang
[not found] ` <1315383059-3673-30-git-send-email-yong.zhang0@gmail.com>
2011-09-07 14:26 ` [PATCH 29/62] block: " Miller, Mike (OS Dev)
[not found] ` <1315383059-3673-52-git-send-email-yong.zhang0@gmail.com>
2011-09-07 17:04 ` [PATCH 51/62] powerpc/ps3: " Geoff Levand
[not found] ` <1315383059-3673-21-git-send-email-yong.zhang0@gmail.com>
2011-09-07 17:12 ` [PATCH 20/62] sparc: " David Miller
2011-09-07 17:31 ` Thomas Gleixner
2011-09-07 17:33 ` Thomas Gleixner
2011-09-07 17:51 ` David Miller
2011-09-07 17:57 ` Thomas Gleixner
2011-09-07 18:14 ` David Miller
2011-09-07 18:43 ` Thomas Gleixner
2011-09-08 3:15 ` Yong Zhang
[not found] ` <1315383059-3673-61-git-send-email-yong.zhang0@gmail.com>
2011-09-07 17:12 ` [PATCH 60/62] sound: " Mark Brown
[not found] ` <1315383059-3673-54-git-send-email-yong.zhang0@gmail.com>
2011-09-07 17:37 ` Grant Likely [this message]
[not found] ` <1315383059-3673-6-git-send-email-yong.zhang0@gmail.com>
2011-09-07 20:29 ` [PATCH 05/62] avr32: " Hans-Christian Egtvedt
[not found] ` <1315383059-3673-13-git-send-email-yong.zhang0@gmail.com>
2011-09-08 3:18 ` [PATCH 12/62] m64k: " Greg Ungerer
2011-09-09 15:05 ` Geert Uytterhoeven
2011-09-10 2:01 ` Yong Zhang
[not found] ` <1315383059-3673-7-git-send-email-yong.zhang0@gmail.com>
2011-09-08 8:12 ` [uclinux-dist-devel] [PATCH 06/62] Blackfin: " Bob Liu
[not found] ` <1315383059-3673-26-git-send-email-yong.zhang0@gmail.com>
2011-09-08 10:40 ` [PATCH 25/62] staging: " Marc Dietich
2011-09-08 13:58 ` Yong Zhang
2011-09-08 14:52 ` Greg KH
2011-09-09 1:12 ` Yong Zhang
[not found] ` <1315383059-3673-3-git-send-email-yong.zhang0@gmail.com>
2011-09-08 10:53 ` [RFC] [PATCH 02/62] mpu401:snd_mpu401_uart_new(): split semantic of irq_flags Clemens Ladisch
2011-09-08 13:37 ` Yong Zhang
2011-09-08 13:58 ` Clemens Ladisch
2011-09-08 14:45 ` Yong Zhang
2011-09-08 20:27 ` Clemens Ladisch
2011-09-09 1:31 ` Yong Zhang
2011-09-11 15:10 ` Clemens Ladisch
2011-09-12 10:47 ` Takashi Iwai
2011-09-12 13:16 ` Clemens Ladisch
2011-09-12 20:23 ` Clemens Ladisch
2011-09-13 7:12 ` Takashi Iwai
2011-09-13 8:17 ` Clemens Ladisch
2011-09-13 9:24 ` Clemens Ladisch
2011-09-14 8:49 ` Yong Zhang
2011-09-14 9:06 ` Takashi Iwai
2011-09-14 9:15 ` Yong Zhang
[not found] ` <1315383059-3673-32-git-send-email-yong.zhang0@gmail.com>
2011-09-08 10:55 ` [PATCH 31/62] driver/char: irq: Remove IRQF_DISABLED Clemens Ladisch
2011-09-08 15:29 ` Corey Minyard
2011-09-08 16:04 ` Arnd Bergmann
[not found] ` <1315383059-3673-62-git-send-email-yong.zhang0@gmail.com>
2011-09-08 21:38 ` [PATCH 61/62] Documentation: irq: Change documents related to IRQF_DISABLED Randy Dunlap
2011-09-09 1:38 ` Yong Zhang
2011-09-09 1:48 ` [UPDATED] " Yong Zhang
2011-09-09 8:25 ` Rolf Eike Beer
2011-09-09 8:41 ` Yong Zhang
[not found] ` <1315383059-3673-37-git-send-email-yong.zhang0@gmail.com>
2011-09-09 7:59 ` [PATCH 36/62] i2c: irq: Remove IRQF_DISABLED Wolfram Sang
2011-09-11 21:36 ` Linus Walleij
2011-09-19 8:44 ` Barry Song
[not found] ` <1315383059-3673-59-git-send-email-yong.zhang0@gmail.com>
2011-09-09 8:01 ` [PATCH 58/62] watchdog: " Wolfram Sang
2011-09-11 21:37 ` Linus Walleij
[not found] ` <1315383059-3673-45-git-send-email-yong.zhang0@gmail.com>
2011-09-09 8:03 ` [PATCH 44/62] mtd: " Wolfram Sang
[not found] ` <1315383059-3673-48-git-send-email-yong.zhang0@gmail.com>
2011-09-09 8:04 ` [PATCH 47/62] pcmcia: " Wolfram Sang
[not found] ` <1315383059-3673-8-git-send-email-yong.zhang0@gmail.com>
2011-09-09 15:10 ` [PATCH 07/62] cris: " Jesper Nilsson
[not found] ` <1315383059-3673-34-git-send-email-yong.zhang0@gmail.com>
2011-09-07 15:02 ` [PATCH 33/62] dmaengine: " Vinod Koul
2011-09-11 21:38 ` Linus Walleij
[not found] ` <1315383059-3673-53-git-send-email-yong.zhang0@gmail.com>
2011-09-11 21:38 ` [PATCH 52/62] rtc: " Linus Walleij
[not found] ` <1315383059-3673-42-git-send-email-yong.zhang0@gmail.com>
2011-09-15 19:57 ` [PATCH 41/62] mfd: " Samuel Ortiz
2011-09-20 15:03 ` [PATCH 08/62] frv: " David Howells
2011-09-20 15:04 ` [PATCH 15/62] mn10300: " David Howells
[not found] ` <1315383059-3673-55-git-send-email-yong.zhang0@gmail.com>
2011-09-09 9:49 ` [PATCH 54/62] TTY: " Tobias Klauser
2011-09-22 23:04 ` Greg KH
2011-09-22 23:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110907173702.GB9937@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=tglx@linutronix.de \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).