From: Greg KH <gregkh@suse.de>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: iommu@lists.linux-foundation.org,
Alex Williamson <alex.williamson@redhat.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
David Woodhouse <dwmw2@infradead.org>,
David Brown <davidb@codeaurora.org>,
joro@8bytes.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/10] IOMMU: Make iommu_ops per-bus_type
Date: Wed, 7 Sep 2011 11:48:40 -0700 [thread overview]
Message-ID: <20110907184840.GB920@suse.de> (raw)
In-Reply-To: <1315410113-26608-1-git-send-email-joerg.roedel@amd.com>
On Wed, Sep 07, 2011 at 05:41:43PM +0200, Joerg Roedel wrote:
> Hi,
>
> here is the new version of the patch-set to make the iommu_ops used in
> the iommu-api a bus_type property. This will allow us to move code out
> of the iommu drivers into generic code and it simplifies the
> implementation of the Alex' device-group property.
>
> Greg, can you have a look at patch 2 please and tell me if you have any
> objections?
I object, please see my comments.
> With this version the patch-set is complete (not as the first RFC post).
> It converts all iommu drivers to use the new registration interface and
> completly removes the register_iommu interface.
>
> Regards,
>
> Joerg
>
> Diffstat:
>
> arch/ia64/kvm/kvm-ia64.c | 3 +-
> arch/x86/kvm/x86.c | 3 +-
> drivers/base/bus.c | 16 ++++++++++
> drivers/iommu/amd_iommu.c | 2 +-
> drivers/iommu/intel-iommu.c | 2 +-
> drivers/iommu/iommu.c | 58 ++++++++++++++++++++++++------------
> drivers/iommu/msm_iommu.c | 2 +-
> drivers/iommu/omap-iommu.c | 2 +-
> drivers/media/video/omap3isp/isp.c | 2 +-
> include/linux/device.h | 9 +++++
> include/linux/iommu.h | 21 +++++++------
> virt/kvm/iommu.c | 4 +-
> 12 files changed, 86 insertions(+), 38 deletions(-)
So the overall work here makes for more code, right? I fail to see the
benifit, what am I missing?
greg k-h
next prev parent reply other threads:[~2011-09-07 18:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 15:41 [PATCH 0/10] IOMMU: Make iommu_ops per-bus_type Joerg Roedel
2011-09-07 15:41 ` [PATCH 01/10] iommu/core: Define iommu_ops and register_iommu only with CONFIG_IOMMU_API Joerg Roedel
2011-09-07 15:41 ` [PATCH 02/10] Driver core: Add iommu_ops to bus_type Joerg Roedel
2011-09-07 18:47 ` Greg KH
2011-09-07 19:19 ` Joerg Roedel
2011-09-07 19:44 ` Greg KH
2011-09-07 20:37 ` Don Dutile
2011-09-08 8:58 ` Joerg Roedel
2011-09-08 8:41 ` Joerg Roedel
2011-09-12 11:40 ` Sethi Varun-B16395
2011-09-13 14:54 ` Roedel, Joerg
2011-09-13 14:58 ` Greg KH
2011-09-13 15:15 ` Roedel, Joerg
2011-09-13 15:38 ` Roedel, Joerg
2011-09-13 16:21 ` Greg KH
2011-09-14 12:46 ` Roedel, Joerg
2011-09-12 12:08 ` Sethi Varun-B16395
2011-09-12 12:35 ` Roedel, Joerg
2011-09-15 12:45 ` Sethi Varun-B16395
2011-09-15 13:13 ` Roedel, Joerg
2011-09-07 15:41 ` [PATCH 03/10] iommu/core: Add bus_type parameter to iommu_domain_alloc Joerg Roedel
2011-09-12 11:50 ` Sethi Varun-B16395
2011-09-12 12:37 ` Roedel, Joerg
2011-09-07 15:41 ` [PATCH 04/10] iommu/core: Convert iommu_found to iommu_present Joerg Roedel
2011-09-07 15:41 ` [PATCH 05/10] iommu/core: Use bus->iommu_ops in the iommu-api Joerg Roedel
2011-09-07 15:41 ` [PATCH 06/10] iommu/amd: Use bus_set_iommu instead of register_iommu Joerg Roedel
2011-09-07 15:41 ` [PATCH 07/10] iommu/vt-d: " Joerg Roedel
2011-09-07 15:41 ` [PATCH 08/10] iommu/omap: " Joerg Roedel
2011-09-07 15:41 ` [PATCH 09/10] iommu/msm: " Joerg Roedel
2011-09-07 15:41 ` [PATCH 10/10] iommu/core: Remove global iommu_ops and register_iommu Joerg Roedel
2011-09-07 18:48 ` Greg KH [this message]
2011-09-07 19:29 ` [PATCH 0/10] IOMMU: Make iommu_ops per-bus_type Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110907184840.GB920@suse.de \
--to=gregkh@suse.de \
--cc=alex.williamson@redhat.com \
--cc=davidb@codeaurora.org \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox