From: Tejun Heo <tj@kernel.org>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Oleg Nesterov <oleg@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Simplify PTRACE_foo constants and PTRACE_SETOPTIONS code
Date: Thu, 8 Sep 2011 09:06:14 +0900 [thread overview]
Message-ID: <20110908000614.GA3987@mtj.dyndns.org> (raw)
In-Reply-To: <201109072336.37300.vda.linux@googlemail.com>
Hello,
Mostly looks good to me. Just a small nit.
On Wed, Sep 07, 2011 at 11:36:37PM +0200, Denys Vlasenko wrote:
> static int ptrace_setoptions(struct task_struct *child, unsigned long data)
> {
> + unsigned flags;
>
> + if (data & ~(long)PTRACE_O_MASK) {
Can we use (unsigned long) here? Signed extensions have a nasty way
of sneaking up on you.
> + child->ptrace &= ~PT_TRACE_MASK; /* historical bug */
And it would be great if it explains what the historical bug was and
what the intended behavior is.
Other than that,
Acked-by: Tejun Heo <tj@kernel.org>
Thank you.
--
tejun
next prev parent reply other threads:[~2011-09-08 0:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 21:36 [PATCH] Simplify PTRACE_foo constants and PTRACE_SETOPTIONS code Denys Vlasenko
2011-09-08 0:06 ` Tejun Heo [this message]
2011-09-08 12:13 ` Denys Vlasenko
2011-09-08 18:37 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110908000614.GA3987@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox