From: Paul Mundt <lethal@linux-sh.org>
To: "Koul, Vinod" <vinod.koul@intel.com>
Cc: "g.liakhovetski@gmx.de" <g.liakhovetski@gmx.de>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"magnus.damm@gmail.com" <magnus.damm@gmail.com>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"damm@opensource.se" <damm@opensource.se>
Subject: Re: [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID
Date: Thu, 8 Sep 2011 10:21:20 +0900 [thread overview]
Message-ID: <20110908012119.GJ22142@linux-sh.org> (raw)
In-Reply-To: <438BB0150E931F4B9CE701519A4463010871804A4F@bgsmsx502.gar.corp.intel.com>
On Thu, Sep 08, 2011 at 03:07:53AM +0530, Koul, Vinod wrote:
> On Wed, 2011-09-07 at 22:01 +0200, Guennadi Liakhovetski wrote:
> > On Thu, 8 Sep 2011, Koul, Vinod wrote:
> > You're seriously suggesting to export and use an additional shdma private
> > function, bypassing the dmaengine API?... That really doesn't sound like a
> > good idea to me, sorry. How about using .device_control(DMA_SLAVE_CONFIG)
> > from the filter function directly to verify channel suitability?
> Yes see stedma40, coh90138 drivers
> .device_control is not right place as channel is already allocated.
>
No, that's not going to happen either. Many of these drivers are used in
different CPUs with different DMACs. The dmaengine driver in question
only applies to a subset, so the driver bits need to be wholly generic.
In short, if the dmaengine API can't handle this sort of stuff then it's
the dmaengine API that needs to be extended, we won't be working around
dmaengine shortcomings in drivers that simply want a sensible DMA API to
plug in to.
next prev parent reply other threads:[~2011-09-08 1:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 11:56 [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID Guennadi Liakhovetski
2011-06-24 11:47 ` Koul, Vinod
2011-08-29 8:00 ` Paul Mundt
2011-08-29 8:16 ` Magnus Damm
2011-08-29 11:55 ` Vinod Koul
2011-08-30 7:54 ` Guennadi Liakhovetski
2011-08-30 10:02 ` Vinod Koul
2011-08-30 11:20 ` Guennadi Liakhovetski
2011-08-30 11:23 ` Vinod Koul
2011-08-30 11:40 ` Guennadi Liakhovetski
2011-09-05 8:04 ` Guennadi Liakhovetski
2011-09-05 13:13 ` Vinod Koul
2011-09-05 13:48 ` Guennadi Liakhovetski
2011-09-05 14:43 ` Vinod Koul
2011-09-05 15:01 ` Guennadi Liakhovetski
2011-09-05 15:08 ` Vinod Koul
2011-09-05 15:21 ` Guennadi Liakhovetski
2011-09-07 18:42 ` Koul, Vinod
2011-09-07 20:01 ` Guennadi Liakhovetski
2011-09-07 21:37 ` Koul, Vinod
2011-09-08 1:21 ` Paul Mundt [this message]
2011-09-08 19:31 ` Vinod Koul
2011-09-14 5:16 ` Vinod Koul
2011-09-14 18:52 ` Alan Cox
2011-09-19 3:13 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110908012119.GJ22142@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=damm@opensource.se \
--cc=dan.j.williams@intel.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox