From: Arnd Bergmann <arnd@arndb.de>
To: Kyungmin Park <kmpark@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <jaxboe@fusionio.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lin Ming <lxy@ss.pku.edu.cn>
Subject: Re: [RFC PATCH v2] support ioctl for tunable user request
Date: Thu, 8 Sep 2011 17:47:52 +0200 [thread overview]
Message-ID: <201109081747.52518.arnd@arndb.de> (raw)
In-Reply-To: <CAH9JG2XST45QSmkbu4kqmuQ-vOS-xdwwz_w_CLepHYpA7z01cA@mail.gmail.com>
On Tuesday 06 September 2011, Kyungmin Park wrote:
> > Would __REQ_GC as a shortcut for garbage collection fit? Right now,
> > I also think TUNE is not at all describing what we expect the drive
> > to do, but it's hard to come up with a term that is generic enough
> > to cover similar concepts in other hardware while still describing
> > what the drive does.
> No problem to use the REQ_GC. BTW, does it acceptable to GC request? I
> hope each devices can do own optimization if REQ_GC is requested, if
> no need to these one, just ignore it at driver level.
I would suggest that you specify exactly what you mean with REQ_GC at the
point where it is defined, e.g.
/*
* REQ_GC -- force garbage collection on the device
*
* The drive is forced to perform a "garbage collection" on data that it
* has recently written. This will keep the device busy within a short
* time span (up to 60 seconds) during which its performance may be
* significantly reduced. After the garbage collection has finished,
* the device is expected to provide optimum write performance again.
*
* User applications that expect expect high continious write throughput
* (such as video recording) should issue a REQ_GC before they start
* recording. A system daemon may occasionally call this during times
* of relative inactivity in order to improve overall performance.
*
* Examples for hardware that should support this include
* - eMMC 4.6 (background operations)
* - SD 3.01 (speed class recording)
* - PCIe based SSD
* - Shingled Hard drives
*
* Drivers that does not require or support garbage collection will
* silently ignore this request.
*/
I'm not sure if that's the definition you need, but I think it should
be at this level of detail.
Arnd
next prev parent reply other threads:[~2011-09-09 1:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 8:15 [RFC PATCH v2] support ioctl for tunable user request Jaehoon Chung
2011-08-29 8:49 ` Lin Ming
2011-08-29 10:11 ` Jaehoon Chung
2011-08-29 14:01 ` Kyungmin Park
2011-08-29 15:17 ` Lin Ming
2011-09-05 8:49 ` Kyungmin Park
2011-09-05 9:15 ` Christoph Hellwig
2011-09-05 11:47 ` Kyungmin Park
2011-09-05 12:18 ` Christoph Hellwig
2011-09-05 12:40 ` Kyungmin Park
2011-09-05 15:04 ` Arnd Bergmann
2011-09-06 4:24 ` Kyungmin Park
2011-09-08 15:47 ` Arnd Bergmann [this message]
2011-09-08 15:54 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109081747.52518.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=hch@infradead.org \
--cc=jaxboe@fusionio.com \
--cc=jh80.chung@samsung.com \
--cc=kmpark@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lxy@ss.pku.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox