From: Andrew Morton <akpm@linux-foundation.org>
To: Jack Steiner <steiner@sgi.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] UV2 - Bug fix for GRU global addresses
Date: Thu, 8 Sep 2011 17:50:44 -0700 [thread overview]
Message-ID: <20110908175044.3d3ee451.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110909002916.GC11894@sgi.com>
On Thu, 8 Sep 2011 19:29:16 -0500 Jack Steiner <steiner@sgi.com> wrote:
> On Thu, Sep 08, 2011 at 04:51:39PM -0700, Andrew Morton wrote:
> > (cc x86 maintainers)
> >
> > On Thu, 8 Sep 2011 13:24:13 -0500
> > Jack Steiner <steiner@sgi.com> wrote:
> >
> > > This patch is a workaround for a UV2 hub bug that affects the format
> > > of system global addresses.
> > >
> > > The GRU API for UV2 was inadvertently broken by a hardware change. The
> > > format of the physical address used for TLB dropins and for addresses used
> > > with instructions running in unmapped mode has changed. This change was not
> > > documented and became apparent only when diags failed running on system simulators.
> > >
> > > For UV1, TLB and GRU instruction physical addresses are identical to socket
> > > physical addresses (although high NASID bits must be OR'ed into the
> > > address).
> > >
> > > For UV2, socket physical addresses need to be converted. The NODE portion of
> > > the physical address needs to be shifted so that the low bit is in bit 39 or
> > > bit 40, depending on an MMR value.
> > >
> > > It is not yet clear if this bug will be fixed in a silicon respin. If it
> > > is fixed, the hub revision will be incremented & the workaround disabled.
> >
> > It's unclear to me whether this patch should be merged into 3.1 and/or
> > into 3.0.x and earlier?
>
> 3.1 is fine. I can push directly to the distros.
Don't do that. It's better for a pile of reasons for this to come via
kernel.org.
Again, what is the case for backporting?
next prev parent reply other threads:[~2011-09-09 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 18:24 [PATCH] UV2 - Bug fix for GRU global addresses Jack Steiner
2011-09-08 23:51 ` Andrew Morton
2011-09-09 0:29 ` Jack Steiner
2011-09-09 0:50 ` Andrew Morton [this message]
2011-09-09 1:55 ` Jack Steiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110908175044.3d3ee451.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steiner@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox