From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757443Ab1IIAqY (ORCPT ); Thu, 8 Sep 2011 20:46:24 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:35311 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756514Ab1IIAqW (ORCPT ); Thu, 8 Sep 2011 20:46:22 -0400 Date: Thu, 8 Sep 2011 17:50:44 -0700 From: Andrew Morton To: Jack Steiner Cc: linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH] UV2 - Bug fix for GRU global addresses Message-Id: <20110908175044.3d3ee451.akpm@linux-foundation.org> In-Reply-To: <20110909002916.GC11894@sgi.com> References: <20110908182413.GA10782@sgi.com> <20110908165139.caa9ddef.akpm@linux-foundation.org> <20110909002916.GC11894@sgi.com> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 8 Sep 2011 19:29:16 -0500 Jack Steiner wrote: > On Thu, Sep 08, 2011 at 04:51:39PM -0700, Andrew Morton wrote: > > (cc x86 maintainers) > > > > On Thu, 8 Sep 2011 13:24:13 -0500 > > Jack Steiner wrote: > > > > > This patch is a workaround for a UV2 hub bug that affects the format > > > of system global addresses. > > > > > > The GRU API for UV2 was inadvertently broken by a hardware change. The > > > format of the physical address used for TLB dropins and for addresses used > > > with instructions running in unmapped mode has changed. This change was not > > > documented and became apparent only when diags failed running on system simulators. > > > > > > For UV1, TLB and GRU instruction physical addresses are identical to socket > > > physical addresses (although high NASID bits must be OR'ed into the > > > address). > > > > > > For UV2, socket physical addresses need to be converted. The NODE portion of > > > the physical address needs to be shifted so that the low bit is in bit 39 or > > > bit 40, depending on an MMR value. > > > > > > It is not yet clear if this bug will be fixed in a silicon respin. If it > > > is fixed, the hub revision will be incremented & the workaround disabled. > > > > It's unclear to me whether this patch should be merged into 3.1 and/or > > into 3.0.x and earlier? > > 3.1 is fine. I can push directly to the distros. Don't do that. It's better for a pile of reasons for this to come via kernel.org. Again, what is the case for backporting?