From: Dan Carpenter <error27@gmail.com>
To: Chris Boot <bootc@bootc.net>
Cc: Arvydas Sidorenko <asido4@gmail.com>,
devel@driverdev.osuosl.org, gregkh@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] typedef cleanup
Date: Fri, 9 Sep 2011 00:30:25 -0700 [thread overview]
Message-ID: <20110909073025.GE17041@mwanda> (raw)
In-Reply-To: <A80909DB-416A-4E81-AEB9-1308366FC693@bootc.net>
On Thu, Sep 08, 2011 at 07:35:37PM +0200, Chris Boot wrote:
> On 4 Sep 2011, at 21:54, Arvydas Sidorenko wrote:
>
> > #ifndef uint64_t
> > -typedef struct _uint64_t {
> > +struct _uint64_t {
> > uint32_t low_dw;
> > uint32_t hi_dw;
> > } uint64_t;
> > #endif
>
> This can't be right can it? You're changing a typedef into a
> variable definition as far as I can see.
Yes. You are right. The "uint64_t" is a variable now so this patch
is wrong.
(Or maybe you knew that and the question was rhetorical? It's hard
to tell over email.)
regards,
dan carpenter
next prev parent reply other threads:[~2011-09-09 7:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-04 19:54 [PATCH 1/3] one typo fix Arvydas Sidorenko
2011-09-04 19:54 ` [PATCH 2/3] syntax typos fix Arvydas Sidorenko
2011-09-04 19:54 ` [PATCH 3/3] typedef cleanup Arvydas Sidorenko
2011-09-08 17:35 ` Chris Boot
2011-09-09 7:30 ` Dan Carpenter [this message]
2011-09-09 8:21 ` Chris Boot
2011-09-06 23:57 ` [PATCH 1/3] one typo fix Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110909073025.GE17041@mwanda \
--to=error27@gmail.com \
--cc=asido4@gmail.com \
--cc=bootc@bootc.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox