From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933093Ab1IIJDD (ORCPT ); Fri, 9 Sep 2011 05:03:03 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:43823 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932889Ab1IIJDB (ORCPT ); Fri, 9 Sep 2011 05:03:01 -0400 Date: Fri, 9 Sep 2011 05:02:57 -0400 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , "Sam Bradshaw (sbradshaw)" , "alan@lxorguk.ukuu.org.uk" , "linux-ide@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jeff Garzik , "jmoyer@redhat.com" , "Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONTRACTOR]" Subject: Re: [PATCH v4] drivers/block/mtip32xx: Adding new driver mtip32xx Message-ID: <20110909090257.GA16871@infradead.org> References: <22A973199D2C2F46933448F6E7990A3002C80026@ntxboimbx31.micron.com> <4E44E782.7090309@fusionio.com> <2A9BE4FF6209B644B6F8EB62DE6AEA1E07663ED4@ntxfrembx01.micron.com> <20110909085433.GA9593@infradead.org> <4E69D519.8070802@fusionio.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E69D519.8070802@fusionio.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 09, 2011 at 10:58:01AM +0200, Jens Axboe wrote: > > - also the call to blk_queue_flush(queue, 0); from ->make_request for > > a non-data request is completely wrong. > > I noticed both of these flush/fua problems too and have fixed them up. Where? Remember that sequencing a pre-flush in a make_request driver is fairly complicated.