* [PATCH] arch/x86/mm/init_32.c: quiet sparse noise; local functions should be static
@ 2011-09-09 23:09 H Hartley Sweeten
2011-09-11 1:07 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2011-09-09 23:09 UTC (permalink / raw)
To: Linux Kernel; +Cc: x86, tglx, mingo, hpa, tj, yinghai, bp
Local functions should be marked static. This quiets the following
sparse noise:
warning: symbol 'lowmem_pfn_init' was not declared. Should it be static?
warning: symbol 'highmem_pfn_init' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers,com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
---
diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
index 29f7c6d..cc56c76 100644
--- a/arch/x86/mm/init_32.c
+++ b/arch/x86/mm/init_32.c
@@ -560,7 +560,7 @@ early_param("highmem", parse_highmem);
* artificially via the highmem=x boot parameter then create
* it:
*/
-void __init lowmem_pfn_init(void)
+static void __init lowmem_pfn_init(void)
{
/* max_low_pfn is 0, we already have early_res support */
max_low_pfn = max_pfn;
@@ -596,7 +596,7 @@ void __init lowmem_pfn_init(void)
* We have more RAM than fits into lowmem - we try to put it into
* highmem, also taking the highmem=x boot parameter into account:
*/
-void __init highmem_pfn_init(void)
+static void __init highmem_pfn_init(void)
{
max_low_pfn = MAXMEM_PFN;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arch/x86/mm/init_32.c: quiet sparse noise; local functions should be static
2011-09-09 23:09 [PATCH] arch/x86/mm/init_32.c: quiet sparse noise; local functions should be static H Hartley Sweeten
@ 2011-09-11 1:07 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2011-09-11 1:07 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, x86, tglx, mingo, hpa, yinghai, bp
On Fri, Sep 09, 2011 at 04:09:23PM -0700, H Hartley Sweeten wrote:
> Local functions should be marked static. This quiets the following
> sparse noise:
>
> warning: symbol 'lowmem_pfn_init' was not declared. Should it be static?
> warning: symbol 'highmem_pfn_init' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers,com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Yinghai Lu <yinghai@kernel.org>
> Cc: Borislav Petkov <bp@alien8.de>
Looks good to me.
Reviewed-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-11 1:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-09 23:09 [PATCH] arch/x86/mm/init_32.c: quiet sparse noise; local functions should be static H Hartley Sweeten
2011-09-11 1:07 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox