From: Greg KH <gregkh@suse.de>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Donggeun Kim <dg77.kim@samsung.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
akpm@linux-foundation.org, jic23@cam.ac.kr,
kyungmin.park@samsung.com
Subject: Re: [PATCH v2] misc: Add driver for GP2AP002 proximity/ambient light sensor
Date: Fri, 9 Sep 2011 09:28:13 -0700 [thread overview]
Message-ID: <20110909162813.GA28470@suse.de> (raw)
In-Reply-To: <4E69D968.2020100@cam.ac.uk>
On Fri, Sep 09, 2011 at 10:16:24AM +0100, Jonathan Cameron wrote:
> On 09/09/11 09:31, Greg KH wrote:
> > On Fri, Sep 09, 2011 at 05:22:26PM +0900, Donggeun Kim wrote:
> >> SHARP GP2AP002 is proximity and ambient light sensor.
> >> This patch supports it.
> >>
> >> Signed-off-by: Donggeun Kim <dg77.kim@samsung.com>
> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> >> ---
> >> Changes for v2
> >> - changed to expose lux
> >> - changed request_irq to request_threaded_irq function
> >> - added sysfs_notify function call
> >
> > Why? You should never do that unless you _really_ know what you are
> > doing.
> My bad. I suggested it was a better bet than doing a uevent to act
> as a data ready notifier...
>
> Greg, for future reference can you clarify why it's a bad idea or
> give a reference (if it's been clarified elsewhere and I missed it!)
uevents are not for general "this sensor changed" type events. They are
for "large" events like "your laptop got docked, your disk got removed,
etc."
They can be very "heavy" so don't use them lightly,
greg k-h
prev parent reply other threads:[~2011-09-09 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 8:22 [PATCH v2] misc: Add driver for GP2AP002 proximity/ambient light sensor Donggeun Kim
2011-09-09 8:31 ` Greg KH
2011-09-09 9:16 ` Jonathan Cameron
2011-09-09 16:28 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110909162813.GA28470@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dg77.kim@samsung.com \
--cc=jic23@cam.ac.kr \
--cc=jic23@cam.ac.uk \
--cc=kyungmin.park@samsung.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).