From: Andrew Morton <akpm@linux-foundation.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Vladimir Zapolskiy <vz@mleia.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] sched: share task comm length value to userspace
Date: Fri, 9 Sep 2011 16:41:30 -0700 [thread overview]
Message-ID: <20110909164130.3bc63ff7.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110905133903.76cd3a61@infradead.org>
On Mon, 5 Sep 2011 13:39:03 -0700
Arjan van de Ven <arjan@infradead.org> wrote:
> On Mon, 05 Sep 2011 23:17:05 +0300
> Vladimir Zapolskiy <vz@mleia.com> wrote:
>
> > but eventually having that value in
> > userspace is really desirable. However in assumption that this value
> > is preserved fixed and won't be changed in reasonable perspective,
> > the presented approach becomes the most evident and simple.
>
> yeah if it would never change, your change would be the most simple.
> but I really don't want to pin that thing down....
>
> >
> > >
> > > If we need to export this, we should export it in /proc or /sys
> > > somewhere as a dynamic value.....
> > >
> > Let's do it in a proper way. What's the common practice to export
> > such limit values? I suppose via /proc/sys/kernel, please correct me,
> > if I'm wrong.
>
> that or /sys/kernel
>
> personally I like /proc/sys/kernel for this kind of thing more, but...
> ... others might disagree.
>
Run this:
#include <sys/prctl.h>
#include <errno.h>
#include <string.h>
#include <stdio.h>
#include <stdlib.h>
main()
{
char comm[512];
int len;
memset(comm, 0, sizeof(comm));
for (len = 1; len < sizeof(comm) - 1; len++) {
char comm2[512];
comm[len - 1] = 'a';
if (prctl(PR_SET_NAME, (unsigned long)comm, 0, 0, 0) < 0) {
fprintf(stderr, "PR_SET_NAME failed with: %s\n",
strerror(errno));
exit(1);
}
if (prctl(PR_GET_NAME, (unsigned long)comm2, 0, 0, 0) < 0) {
fprintf(stderr, "PR_SET_NAME failed with: %s\n",
strerror(errno));
exit(1);
}
if (strlen(comm2) != len) {
printf("%d\n", len);
break;
}
}
exit(0);
}
once per boot, echoing the result into /etc/sizeof-comm. Sell resulting
package to all vendors ;)
next prev parent reply other threads:[~2011-09-09 23:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 18:38 [PATCH] sched: share task comm length value to userspace Vladimir Zapolskiy
2011-09-05 19:47 ` Arjan van de Ven
2011-09-05 20:17 ` Vladimir Zapolskiy
2011-09-05 20:39 ` Arjan van de Ven
2011-09-09 23:41 ` Andrew Morton [this message]
2011-09-09 23:49 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110909164130.3bc63ff7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox