From: Andrew Morton <akpm@linux-foundation.org>
To: Arjan van de Ven <arjan@infradead.org>,
Vladimir Zapolskiy <vz@mleia.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] sched: share task comm length value to userspace
Date: Fri, 9 Sep 2011 16:49:59 -0700 [thread overview]
Message-ID: <20110909164959.237a8612.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110909164130.3bc63ff7.akpm@linux-foundation.org>
On Fri, 9 Sep 2011 16:41:30 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> if (prctl(PR_GET_NAME, (unsigned long)comm2, 0, 0, 0) < 0) {
Actually, if we were ever to increase sizeof(task_struct.comm),
existing code which does
char comm[16];
prctl(PR_GET_NAME, comm, ...)
will get its stack scribbled on.
So we _could_ increase it, but we'd need to retain the old 16-char
interfaces and add new prctl() modes. And if we did that, we'd design
them in such a way that userspace wouldn't need to assume a fixed
size..
prev parent reply other threads:[~2011-09-09 23:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 18:38 [PATCH] sched: share task comm length value to userspace Vladimir Zapolskiy
2011-09-05 19:47 ` Arjan van de Ven
2011-09-05 20:17 ` Vladimir Zapolskiy
2011-09-05 20:39 ` Arjan van de Ven
2011-09-09 23:41 ` Andrew Morton
2011-09-09 23:49 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110909164959.237a8612.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox