From: Greg KH <greg@kroah.com>
To: Nitin Gupta <ngupta@vflare.org>
Cc: Jerome Marchand <jmarchan@redhat.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
Linux Driver Project <devel@linuxdriverproject.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5 resend] Fix sparse warnings
Date: Fri, 9 Sep 2011 13:30:19 -0700 [thread overview]
Message-ID: <20110909203019.GA19140@kroah.com> (raw)
In-Reply-To: <4E6A4AA7.5050004@vflare.org>
On Fri, Sep 09, 2011 at 01:19:35PM -0400, Nitin Gupta wrote:
> Fixes sparse warning:
> zram_drv.c:666:6: warning: symbol 'zram_slot_free_notify' was not
> declared. Should it be static?
>
> Also, max_zpage_size is now size_t just to be consistent with data-type
> of other variables maintaining sizes of various kinds.
>
> Signed-off-by: Nitin Gupta <ngupta@vflare.org>
> ---
> drivers/staging/zram/zram_drv.c | 3 ++-
> drivers/staging/zram/zram_drv.h | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
Close, but can you please resend the series with a proper Subject: line
that shows what subsystem/driver this is for? I explained how to do
this properly in a prior email.
thanks,
greg k-h
next prev parent reply other threads:[~2011-09-09 20:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 1:29 [PATCH 0/5 v2] zram: minor features and cleanups Nitin Gupta
2011-09-08 1:29 ` [PATCH 1/5] Fix sparse warnings Nitin Gupta
2011-09-08 8:17 ` Jerome Marchand
2011-09-08 15:13 ` Nitin Gupta
2011-09-08 17:32 ` Harvey Harrison
2011-09-09 17:00 ` Nitin Gupta
2011-09-09 17:11 ` Dan Carpenter
2011-09-09 17:19 ` [PATCH 1/5 resend] " Nitin Gupta
2011-09-09 20:30 ` Greg KH [this message]
2011-09-08 1:29 ` [PATCH 2/5] Kernel config option for number of devices Nitin Gupta
2011-09-08 1:29 ` [PATCH 3/5] Make gobal variables use unique names Nitin Gupta
2011-09-08 1:29 ` [PATCH 4/5] Simplify zram disk resizing interface Nitin Gupta
2011-09-08 1:29 ` [PATCH 5/5] Set initial disksize to some default value Nitin Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110909203019.GA19140@kroah.com \
--to=greg@kroah.com \
--cc=devel@linuxdriverproject.org \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=penberg@cs.helsinki.fi \
--cc=rcj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox