From: Dan Carpenter <error27@gmail.com>
To: Mark Einon <mark.einon@gmail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, o.hartmann@telovital.com
Subject: Re: [PATCH 1/2] staging: et131x: Fix checkpatch whitespace warnings
Date: Fri, 9 Sep 2011 22:22:07 -0700 [thread overview]
Message-ID: <20110910052207.GA4807@mwanda> (raw)
In-Reply-To: <1315050547-4781-1-git-send-email-mark.einon@gmail.com>
On Sat, Sep 03, 2011 at 12:49:06PM +0100, Mark Einon wrote:
> --- a/drivers/staging/et131x/et131x_netdev.c
> +++ b/drivers/staging/et131x/et131x_netdev.c
> @@ -408,7 +408,7 @@ void et131x_tx_timeout(struct net_device *netdev)
> unsigned long flags;
>
> /* If the device is closed, ignore the timeout */
> - if (~(adapter->flags & fMP_ADAPTER_INTERRUPT_IN_USE));
> + if (~(adapter->flags & fMP_ADAPTER_INTERRUPT_IN_USE))
> return;
>
You fixed a bug here. That's not mentioned in the commit message.
Why would you want to keep that a secret? Also it should go in a
separate commit.
But otherwise this patch looks good.
regards,
dan carpenter
next prev parent reply other threads:[~2011-09-10 5:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-03 11:49 [PATCH 1/2] staging: et131x: Fix checkpatch whitespace warnings Mark Einon
2011-09-03 11:49 ` [PATCH 2/2] staging: et131x: Amend README file Mark Einon
2011-09-10 5:22 ` Dan Carpenter [this message]
2011-09-10 16:34 ` [PATCH 1/2] staging: et131x: Fix checkpatch whitespace warnings Mark Einon
2011-09-10 5:41 ` Joe Perches
2011-09-10 16:40 ` Mark Einon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110910052207.GA4807@mwanda \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.einon@gmail.com \
--cc=o.hartmann@telovital.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox