From: "Henrik Rydberg" <rydberg@euromail.se>
To: Javier Martinez Canillas <martinez.javier@gmail.com>
Cc: Kevin McNeely <kev@cypress.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/3] Input: cyttsp - Cypress TTSP capacitive multi-touch screen support
Date: Tue, 13 Sep 2011 10:24:48 +0200 [thread overview]
Message-ID: <20110913082448.GA5046@polaris.bitmath.org> (raw)
In-Reply-To: <1315029042-27513-2-git-send-email-martinez.javier@gmail.com>
Hi Javier,
> Cypress TrueTouch(tm) Standard Product controllers are found in
> a wide range of embedded devices. This driver add support for a
> variety of TTSP controllers.
>
> The driver is composed of a core driver that process the data sent by
> the contacts and a set of bus specific interface modules. This patch
> adds the base core TTSP driver.
>
> The original author of the driver is Kevin McNeely <kev@cypress.com>
>
> Since the hardware is capable of tracking identifiable contacts and the
> original driver used multi-touch protocol type A (stateless), multi-touch
> protocol type B (stateful) support was added by Javier Martinez Canillas.
>
> Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
> ---
> Changes since v1: Fix issues called out by Dmitry Torokhov
> - Add msleep() delays between retries for read and write operations
> - Change cyttsp_core_init() to receive the IRQ from the client data
> instead of obtaining from the platform_data
Compared to the staging version you sent earlier, this version seems
to be a step back towards the original version regarding the MT
implementation. Is this the right patch?
Thanks,
Henrik
next prev parent reply other threads:[~2011-09-13 8:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-03 5:50 [PATCH V2 0/3] Input: Cypress TTSP device driver Javier Martinez Canillas
2011-09-03 5:50 ` [PATCH V2 1/3] Input: cyttsp - Cypress TTSP capacitive multi-touch screen support Javier Martinez Canillas
2011-09-13 8:24 ` Henrik Rydberg [this message]
2011-09-14 7:14 ` Javier Martinez Canillas
2011-09-14 7:46 ` Henrik Rydberg
2011-09-14 21:03 ` Javier Martinez Canillas
2011-09-14 10:50 ` Mohan Pallaka
2011-09-14 22:32 ` Javier Martinez Canillas
2011-09-03 5:50 ` [PATCH V2 2/3] Input: cyttsp - add support for Cypress TTSP touchscreen I2C bus interface Javier Martinez Canillas
2011-09-03 5:50 ` [PATCH V2 3/3] Input: cyttsp - add support for Cypress TTSP touchscreen SPI " Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110913082448.GA5046@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@suse.de \
--cc=kev@cypress.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martinez.javier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox