From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754445Ab1IMOiC (ORCPT ); Tue, 13 Sep 2011 10:38:02 -0400 Received: from mail-ew0-f52.google.com ([209.85.215.52]:60916 "EHLO mail-ew0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753934Ab1IMOiA (ORCPT ); Tue, 13 Sep 2011 10:38:00 -0400 Date: Tue, 13 Sep 2011 16:37:54 +0200 From: Frederic Weisbecker To: Peter Zijlstra Cc: Andrew Morton , LKML , Paul Menage , Li Zefan , Johannes Weiner , Aditya Kali , Oleg Nesterov , Kay Sievers , Tim Hockin , Tejun Heo , Containers Subject: Re: [PATCH 00/11 v5] cgroups: Task counter subsystem Message-ID: <20110913143749.GA23424@somewhere> References: <1315869091-18933-1-git-send-email-fweisbec@gmail.com> <1315924371.5977.16.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1315924371.5977.16.camel@twins> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2011 at 04:32:51PM +0200, Peter Zijlstra wrote: > On Tue, 2011-09-13 at 01:11 +0200, Frederic Weisbecker wrote: > > kernel/cgroup_task_counter.c | 239 ++++++++++++++++++++++++++++ > > Horrible name, since it does more than just count, it also limits the > number of tasks. cgroup_task_count_limit.c ? ;) Because cgroup_task_limit.c sounds way too much generic to be self-explanatory. I believe a better thing would be to create kernel/cgroup/ and move things like cgroup.c, cgroup_freezer.c (renamed into freezer.c in that directory) and have task_count_limit.c inside.