From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
David Ahern <dsahern@gmail.com>,
linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [PATCH] perf: make perf.data more self-descriptive (v4)
Date: Tue, 13 Sep 2011 11:40:51 -0300 [thread overview]
Message-ID: <20110913144051.GA23034@ghostprotocols.net> (raw)
In-Reply-To: <CABPqkBSJdCahCugQDyJnoKrB3iFh-yEWNF4Ckm0pRjbcFiKvkA@mail.gmail.com>
Em Mon, Sep 12, 2011 at 04:47:21PM +0200, Stephane Eranian escreveu:
> On Mon, Sep 12, 2011 at 4:43 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Mon, 2011-09-12 at 16:40 +0200, Stephane Eranian wrote:
> >> I don't think this should be the test to detect endianess.
> >
> > You should be able to tell the endianness from the PERF_MAGIC string, it
> > stores the string as a u64, so depending on endianness it reads back as
> > either: PERFFILE or ELIFFREP or whatever the bswap64 result is.
> >
> right, something like that...
Yeah, right, reading this thread I could swear it was done like that :-\
Just set needs_swap based on the magic number in perf_file_header__read().
- Arnaldo
next prev parent reply other threads:[~2011-09-13 14:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 19:10 [PATCH] perf: make perf.data more self-descriptive (v4) Stephane Eranian
2011-09-08 15:27 ` David Ahern
[not found] ` <CABPqkBRKcxeTDMyVYPXU6AQEY-Hp2bnE03ebEtvjYWde2JKqoQ@mail.gmail.com>
2011-09-08 15:37 ` David Ahern
2011-09-08 15:42 ` Stephane Eranian
2011-09-12 13:45 ` David Ahern
2011-09-12 13:54 ` Stephane Eranian
2011-09-12 14:33 ` David Ahern
2011-09-12 14:40 ` Stephane Eranian
2011-09-12 14:43 ` Peter Zijlstra
2011-09-12 14:47 ` Stephane Eranian
2011-09-13 14:40 ` Arnaldo Carvalho de Melo [this message]
2011-09-16 14:35 ` Stephane Eranian
2011-09-16 14:37 ` Peter Zijlstra
2011-09-16 14:44 ` Stephane Eranian
2011-09-16 14:52 ` David Ahern
2011-09-16 14:56 ` Stephane Eranian
2011-09-16 14:50 ` David Ahern
2011-09-16 15:19 ` Peter Zijlstra
2011-09-16 15:33 ` David Ahern
2011-09-16 15:42 ` Peter Zijlstra
2011-09-16 16:34 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110913144051.GA23034@ghostprotocols.net \
--to=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox