From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755404Ab1IMQVf (ORCPT ); Tue, 13 Sep 2011 12:21:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52299 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755230Ab1IMQVe (ORCPT ); Tue, 13 Sep 2011 12:21:34 -0400 Date: Tue, 13 Sep 2011 18:21:26 +0200 From: Greg KH To: "Roedel, Joerg" Cc: Joerg Roedel , "iommu@lists.linux-foundation.org" , Alex Williamson , Ohad Ben-Cohen , David Woodhouse , David Brown , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 02/10] Driver core: Add iommu_ops to bus_type Message-ID: <20110913162126.GA6184@suse.de> References: <1315410113-26608-1-git-send-email-joerg.roedel@amd.com> <1315410113-26608-3-git-send-email-joerg.roedel@amd.com> <20110907184750.GA920@suse.de> <20110907191919.GA31674@8bytes.org> <20110907194445.GA2526@suse.de> <20110913145402.GM11701@amd.com> <20110913145855.GA4581@suse.de> <20110913153811.GO11701@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110913153811.GO11701@amd.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2011 at 05:38:11PM +0200, Roedel, Joerg wrote: > On Tue, Sep 13, 2011 at 10:58:55AM -0400, Greg KH wrote: > > On Tue, Sep 13, 2011 at 04:54:02PM +0200, Roedel, Joerg wrote: > > > --- a/include/linux/device.h > > > +++ b/include/linux/device.h > > > @@ -22,6 +22,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > > Ick, please don't add new #includes to device.h, it makes the whole > > build slower. Just pre-declare the structure and all should be fine. > > Hmm, since linux/iommu.h provides 'struct iommu_ops', and this patch > adds a 'struct iommu_ops' to 'struct bus_type', wouldn't a simple > forward declaration make the bus_type incomplete in most other places? No, just like it doesn't make iommu.h incomplete as you used a struct bus_type there. > To lower the impact I can move the 'struct iommu_ops' to a seperate > header file instead. No, that should not be necessary. greg k-h