* [PATCH] lib/sha1.c: quite sparse noise about symbol not declared
@ 2011-09-09 18:30 H Hartley Sweeten
2011-09-13 21:58 ` msb
0 siblings, 1 reply; 3+ messages in thread
From: H Hartley Sweeten @ 2011-09-09 18:30 UTC (permalink / raw)
To: Linux Kernel; +Cc: msb
Include <linux/cryptohash.h> to pickup the declarations for sha_transform
and sha_init to quite the sparse noise:
warning: symbol 'sha_transform' was not declared. Should it be static?
warning: symbol 'sha_init' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Mandeep Singh Baines <msb@chromium.org>
---
diff --git a/lib/sha1.c b/lib/sha1.c
index f33271d..1de509a 100644
--- a/lib/sha1.c
+++ b/lib/sha1.c
@@ -8,6 +8,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/bitops.h>
+#include <linux/cryptohash.h>
#include <asm/unaligned.h>
/*
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] lib/sha1.c: quite sparse noise about symbol not declared
2011-09-09 18:30 [PATCH] lib/sha1.c: quite sparse noise about symbol not declared H Hartley Sweeten
@ 2011-09-13 21:58 ` msb
2011-09-22 11:33 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: msb @ 2011-09-13 21:58 UTC (permalink / raw)
To: H Hartley Sweeten
Cc: Linux Kernel, Herbert Xu, David S. Miller, linux-crypto,
Linus Torvalds
+cc linux-crypto, herbert, davem, torvalds
H Hartley Sweeten (hartleys@visionengravers.com) wrote:
> Include <linux/cryptohash.h> to pickup the declarations for sha_transform
> and sha_init to quite the sparse noise:
>
> warning: symbol 'sha_transform' was not declared. Should it be static?
> warning: symbol 'sha_init' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Mandeep Singh Baines <msb@chromium.org>
>
Acked-by: Mandeep Singh Baines <msb@chromium.org>
Thanks.
> ---
>
> diff --git a/lib/sha1.c b/lib/sha1.c
> index f33271d..1de509a 100644
> --- a/lib/sha1.c
> +++ b/lib/sha1.c
> @@ -8,6 +8,7 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/bitops.h>
> +#include <linux/cryptohash.h>
> #include <asm/unaligned.h>
>
> /*
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lib/sha1.c: quite sparse noise about symbol not declared
2011-09-13 21:58 ` msb
@ 2011-09-22 11:33 ` Herbert Xu
0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2011-09-22 11:33 UTC (permalink / raw)
To: msb
Cc: H Hartley Sweeten, Linux Kernel, David S. Miller, linux-crypto,
Linus Torvalds
On Tue, Sep 13, 2011 at 02:58:51PM -0700, msb@google.com wrote:
> +cc linux-crypto, herbert, davem, torvalds
>
> H Hartley Sweeten (hartleys@visionengravers.com) wrote:
> > Include <linux/cryptohash.h> to pickup the declarations for sha_transform
> > and sha_init to quite the sparse noise:
> >
> > warning: symbol 'sha_transform' was not declared. Should it be static?
> > warning: symbol 'sha_init' was not declared. Should it be static?
> >
> > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> > Cc: Mandeep Singh Baines <msb@chromium.org>
> >
>
> Acked-by: Mandeep Singh Baines <msb@chromium.org>
Patch applied. Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-22 11:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-09 18:30 [PATCH] lib/sha1.c: quite sparse noise about symbol not declared H Hartley Sweeten
2011-09-13 21:58 ` msb
2011-09-22 11:33 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox