From: Russell King <rmk+alsa@arm.linux.org.uk>
To: Axel Lin <axel.lin@gmail.com>, Harald Welte <laforge@openezx.org>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [linux-next] ASoC: sound/soc/samsung/neo1973_wm8753.c build failure
Date: Wed, 14 Sep 2011 20:19:17 +0100 [thread overview]
Message-ID: <20110914191917.GA30518@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1315991893.17271.2.camel@phoenix>
On Wed, Sep 14, 2011 at 05:18:13PM +0800, Axel Lin wrote:
> Hi,
>
> I got below build error: ( on linux-next 20110831 )
> CC sound/soc/samsung/neo1973_wm8753.o
> sound/soc/samsung/neo1973_wm8753.c: In function 'neo1973_wm8753_init':
> sound/soc/samsung/neo1973_wm8753.c:325: error: implicit declaration of function 'machine_is_neo1973_gta01'
> make[3]: *** [sound/soc/samsung/neo1973_wm8753.o] Error 1
> make[2]: *** [sound/soc/samsung] Error 2
> make[1]: *** [sound/soc] Error 2
> make: *** [sound] Error 2
>
> I think the root cause is below commit:
> commit 6f82f4db "ARM: Update (and cut down) mach-types"
> removes neo1973_gta01 entry.
>
> I'm not sure if we should add back the neo1973_gta01 entry to mach-types or
> remove all machine_is_neo1973_gta01() calls in neo1973_wm8753.c.
> Comments?
neo1973_gta01 was added to the database in October 2006. Five months
later, neo1973_gta02 was registered by the same person (Harald Welte),
and gta02 has been merged.
Therefore, I suggest that the GTA01 will never be submitted now, moreover
I suggest that neo1973_gta01 was probably a prototype and neo1973_gta02
was probably the production platform.
So I suggest these references should be removed. If the platform is not
going to be merged its pointless carrying the baggage around in drivers.
Maybe Harald can confirm?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2011-09-14 19:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 9:18 [linux-next] ASoC: sound/soc/samsung/neo1973_wm8753.c build failure Axel Lin
2011-09-14 19:19 ` Russell King [this message]
2011-09-14 23:28 ` Mark Brown
2011-09-14 23:38 ` Russell King
2011-09-15 9:46 ` Mark Brown
2011-09-15 11:00 ` Russell King
2011-09-15 11:53 ` Lars-Peter Clausen
2011-09-15 12:06 ` Russell King
2011-09-16 17:02 ` Valdis.Kletnieks
2011-09-16 20:03 ` Russell King
2011-09-15 13:31 ` Mark Brown
2011-09-15 19:16 ` Russell King
2011-09-15 22:39 ` Mark Brown
2011-09-15 7:20 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110914191917.GA30518@flint.arm.linux.org.uk \
--to=rmk+alsa@arm.linux.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=laforge@openezx.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox