public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Leopold Palomo-Avellaneda <leo@alaxarxa.net>
Cc: linux-kernel@vger.kernel.org, linux-parport@lists.infradead.org,
	630593@bugs.debian.org,
	Nicos Gollan <gollan@informatik.uni-kl.de>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Alexander Gordeev <lasaine@lvk.cs.msu.su>,
	Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH/RFC] parport_pc: remove ancient, overeager quirk that disables EPP support on many chipsets
Date: Thu, 15 Sep 2011 12:16:43 +0200	[thread overview]
Message-ID: <20110915101643.GA10802@kroah.com> (raw)
In-Reply-To: <201109151133.19211.leo@alaxarxa.net>

On Thu, Sep 15, 2011 at 11:33:18AM +0200, Leopold Palomo-Avellaneda wrote:
> Hi,
> 
> there's a bug in the parport module that have been reported (in another 
> places) some time ago [1]. Also, this bug was reported at Redhat [2], but 
> nobody follow the report and it was closed.
> 
> As Adam baked said [1] :
> 
> <quote>
> A long time ago (~ 10 years), Intel produced a chipset that 
> included broken EPP support. The Linux parport driver was written to detect 
> such a chipset and disable EPP support on it. Unfortunately the test that was 
> written gives false positives for many current chipsets and no-one seems to 
> know exactly what the problem hardware was, let alone have a sample of it to 
> see if a better test can be written. After such a long time it is probably 
> appropriate to just remove the test (on average it does more harm than good) 
> however you are correct in asserting the driver is unmaintained so no-one is 
> bothering to fix it.
> </quote>
> 
> I have applied the patch to the standard debian kernel and vanilla kernels and 
> runs perfectly. The patch simply erases a check. Applied to some Dell 
> hardware, now the EPP mode is detected and, after some initial tests it's 
> working.
> 
> Please, apply the patch.

Please resend it with the proper Signed-off-by: line, as described by
Documentation/SubmittingPatches and we will be glad to consider it.

thanks,

greg k-h

  reply	other threads:[~2011-09-15 10:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15  9:33 [PATCH/RFC] parport_pc: remove ancient, overeager quirk that disables EPP support on many chipsets Leopold Palomo-Avellaneda
2011-09-15 10:16 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-09-15 12:41 Leopold Palomo-Avellaneda
2011-09-15 13:35 ` Greg KH
2011-09-15 17:39   ` Jonathan Nieder
2011-09-15 20:23     ` Adam Baker
2011-09-15 20:35       ` Jonathan Nieder
2011-09-16 10:09         ` Leopold Palomo-Avellaneda
2011-09-15 13:41 ` Bastien ROUCARIES
2011-09-15 13:44   ` Bastien ROUCARIES
2011-09-16 10:39     ` Leopold Palomo-Avellaneda
2011-09-15 19:43   ` Jonathan Nieder
2011-09-15 13:02 Leopold Palomo-Avellaneda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110915101643.GA10802@kroah.com \
    --to=greg@kroah.com \
    --cc=630593@bugs.debian.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gollan@informatik.uni-kl.de \
    --cc=jrnieder@gmail.com \
    --cc=lasaine@lvk.cs.msu.su \
    --cc=leo@alaxarxa.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parport@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox