From: Samuel Ortiz <sameo@linux.intel.com>
To: Mattias Wallin <mattias.wallin@stericsson.com>
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Linus Walleij <linus.walleij@stericsson.com>
Subject: Re: [PATCH 1/2] mfd: ab5500 chip register access
Date: Thu, 15 Sep 2011 16:01:33 +0200 [thread overview]
Message-ID: <20110915140133.GC32263@sortiz-mobl> (raw)
In-Reply-To: <1307616640-2013-1-git-send-email-mattias.wallin@stericsson.com>
Hi Mattias,
On Thu, Jun 09, 2011 at 12:50:40PM +0200, Mattias Wallin wrote:
> The analog baseband chip ab5500 is a multi functional chip
> containing regulators, charging, gpio, USB and accessory detect.
> It also contain various multimedia functionalities like digital
> encoder and audio codec.
> The core driver added with this patch provides register access via
> i2c via PRCMU. Event handling implemented as irq_chip will come in
> future patches since it depends on PRCMU functionality not yet
> implemented.
This patch looks good to me. However, I think the 800 lines of debugfs code
could live in an ab5500-debugfs.c file. Could you please do that ?
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2011-09-15 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 10:50 [PATCH 1/2] mfd: ab5500 chip register access Mattias Wallin
2011-08-02 10:02 ` Linus Walleij
2011-08-23 14:22 ` Linus Walleij
2011-09-15 14:01 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110915140133.GC32263@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mattias.wallin@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox