* [PATCH] ASoC: tpa6130a2: Remove obsolete cleanup for clientdata
@ 2011-09-09 8:47 Axel Lin
2011-09-09 9:41 ` Péter Ujfalusi
2011-09-16 9:14 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2011-09-09 8:47 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Ujfalusi, Wolfram Sang, Liam Girdwood, Mark Brown,
alsa-devel
The i2c core will clear the clientdata pointer automatically,
we don't have to set the `data' field to NULL in remove() or
if probe() failed anymore.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/tpa6130a2.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/tpa6130a2.c b/sound/soc/codecs/tpa6130a2.c
index 239e0c4..b2572c4 100644
--- a/sound/soc/codecs/tpa6130a2.c
+++ b/sound/soc/codecs/tpa6130a2.c
@@ -446,7 +446,6 @@ err_regulator:
gpio_free(data->power_gpio);
err_gpio:
kfree(data);
- i2c_set_clientdata(tpa6130a2_client, NULL);
tpa6130a2_client = NULL;
return ret;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: tpa6130a2: Remove obsolete cleanup for clientdata
2011-09-09 8:47 [PATCH] ASoC: tpa6130a2: Remove obsolete cleanup for clientdata Axel Lin
@ 2011-09-09 9:41 ` Péter Ujfalusi
2011-09-16 9:14 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Péter Ujfalusi @ 2011-09-09 9:41 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Wolfram Sang, Liam Girdwood, Mark Brown, alsa-devel
On Friday 09 September 2011 16:47:00 Axel Lin wrote:
> The i2c core will clear the clientdata pointer automatically,
> we don't have to set the `data' field to NULL in remove() or
> if probe() failed anymore.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: tpa6130a2: Remove obsolete cleanup for clientdata
2011-09-09 8:47 [PATCH] ASoC: tpa6130a2: Remove obsolete cleanup for clientdata Axel Lin
2011-09-09 9:41 ` Péter Ujfalusi
@ 2011-09-16 9:14 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-09-16 9:14 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Peter Ujfalusi, Wolfram Sang, Liam Girdwood,
alsa-devel
On Fri, Sep 09, 2011 at 04:47:00PM +0800, Axel Lin wrote:
> The i2c core will clear the clientdata pointer automatically,
> we don't have to set the `data' field to NULL in remove() or
> if probe() failed anymore.
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-16 9:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-09 8:47 [PATCH] ASoC: tpa6130a2: Remove obsolete cleanup for clientdata Axel Lin
2011-09-09 9:41 ` Péter Ujfalusi
2011-09-16 9:14 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox