From: Greg KH <gregkh@suse.de>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: linux-kernel@vger.kernel.org, Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] sysfs: add per pci device msi[x] irq listing (v2)
Date: Fri, 16 Sep 2011 15:23:19 +0200 [thread overview]
Message-ID: <20110916132319.GC8973@suse.de> (raw)
In-Reply-To: <20110916105716.GA32672@hmsreliant.think-freely.org>
On Fri, Sep 16, 2011 at 06:57:16AM -0400, Neil Horman wrote:
> On Fri, Sep 16, 2011 at 10:36:46AM +0200, Greg KH wrote:
> > On Thu, Sep 15, 2011 at 04:08:38PM -0400, Neil Horman wrote:
> > > +static struct kobj_type msi_irq_ktype = {
> > > + .sysfs_ops = &msi_irq_sysfs_ops,
> > > + .default_attrs = msi_irq_default_attrs,
> > > +};
> >
> > You still haven't successfully removed the kobject associated with this
> > kobj_type. Otherwise you would have seen the error messages in the
> > kernel log and fixed up what it told you to fix.
> >
> > Please do so.
> >
> Well, I'm not using kobject_del, you're right, I'm just using a kobject_put, and
> I swear I'm not getting any error messages about it:
Then you really are not ever freeing that kobject, so there's a
reference counting bug in your code which you need to fix.
You will notice the real problem once you try to finally release that
kobject, trust me :)
greg k-h
next prev parent reply other threads:[~2011-09-16 13:29 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 18:36 [PATCH] sysfs: add per pci device msi[x] irq listing Neil Horman
2011-09-15 14:40 ` Greg KH
2011-09-15 15:07 ` Neil Horman
2011-09-15 20:08 ` [PATCH] sysfs: add per pci device msi[x] irq listing (v2) Neil Horman
2011-09-16 8:36 ` Greg KH
2011-09-16 10:57 ` Neil Horman
2011-09-16 13:23 ` Greg KH [this message]
2011-09-16 13:32 ` Neil Horman
2011-09-16 16:12 ` Bjorn Helgaas
2011-09-19 15:47 ` [PATCH] sysfs: add per pci device msi[x] irq listing (v3) Neil Horman
2011-09-19 17:14 ` Greg KH
2011-09-19 17:33 ` Neil Horman
2011-09-22 10:49 ` Konrad Rzeszutek Wilk
2011-09-22 10:57 ` Neil Horman
2011-09-22 11:10 ` Konrad Rzeszutek Wilk
2011-09-22 13:21 ` Neil Horman
2011-09-22 13:17 ` Neil Horman
2011-09-22 13:54 ` Matthew Wilcox
2011-09-22 14:32 ` Neil Horman
2011-09-28 22:18 ` Bjorn Helgaas
2011-09-29 0:42 ` Neil Horman
2011-09-29 4:40 ` Bjorn Helgaas
2011-09-29 13:07 ` Neil Horman
2011-09-29 14:38 ` [PATCH] sysfs: add per pci device msi[x] irq listing (v4) Neil Horman
2011-09-29 14:51 ` Greg KH
2011-09-30 12:32 ` Stefan Richter
2011-09-30 15:33 ` Neil Horman
2011-09-30 16:33 ` Bjorn Helgaas
2011-09-30 16:54 ` Neil Horman
2011-10-06 15:36 ` Jesse Barnes
2011-10-06 17:12 ` Neil Horman
2011-10-06 17:57 ` Bjorn Helgaas
2011-10-06 18:08 ` [PATCH] sysfs: add per pci device msi[x] irq listing (v5) Neil Horman
2011-10-14 16:21 ` Jesse Barnes
2011-10-14 16:40 ` Greg KH
2011-10-14 17:31 ` Neil Horman
2011-11-01 16:47 ` Neil Horman
2011-11-01 16:58 ` Jesse Barnes
2011-11-01 18:05 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110916132319.GC8973@suse.de \
--to=gregkh@suse.de \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox