From: xingchao <xingchao.wang@intel.com>
To: Paul Turner <pjt@google.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@elte.hu" <mingo@elte.hu>,
"peterz@infradead.org" <peterz@infradead.org>,
"yong.zhang0@gmail.com" <yong.zhang0@gmail.com>,
"Shi, Alex" <alex.shi@intel.com>
Subject: Re: [PATCH] cfs: NULL pointer check
Date: Fri, 16 Sep 2011 17:18:52 -0400 [thread overview]
Message-ID: <20110916171852.17f75ce6@wang-bj-intel> (raw)
In-Reply-To: <4E72FDF1.3080608@google.com>
On Fri, 16 Sep 2011 15:42:41 +0800
Paul Turner <pjt@google.com> wrote:
> On 09/16/11 10:48, Wang Xingchao wrote:
> > se maybe NULL if cfs_rq->rb_leftmost is NULL
>
> nack, it had better not be; otherwise we've got a corrupt tree!
>
> Also, this diff is against the previous -- please bundle dependent
> patches as a series in the future.
>
Got it. :)
Paul, i'd send another patch to remove the NULL pointer check
in __pick_first/last_entity().
--xingchao
prev parent reply other threads:[~2011-09-16 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 17:48 [PATCH] cfs: NULL pointer check Wang Xingchao
2011-09-16 5:57 ` Yong Zhang
2011-09-16 7:42 ` Paul Turner
2011-09-16 21:18 ` xingchao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110916171852.17f75ce6@wang-bj-intel \
--to=xingchao.wang@intel.com \
--cc=alex.shi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox