RE: [PATCH 20/20] Staging: hv: netvsc: Rename deviceInfo as device_info

KY Srinivasan
2011-09-13T18:15:33Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1465 bytes --]

> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: Tuesday, September 13, 2011 2:11 PM
> To: KY Srinivasan
> Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang
> Subject: Re: [PATCH 20/20] Staging: hv: netvsc: Rename deviceInfo as
> device_info
>
> On Tue, 2011-09-13 at 10:59 -0700, K. Y. Srinivasan wrote:
> > Rename deviceInfo as device_info.
> []
> > diff --git a/drivers/staging/hv/rndis_filter.c b/drivers/staging/hv/rndis_filter.c
> []
> > @@ -732,15 +732,15 @@ int rndis_filter_device_add(struct hv_device *dev,
> []
> > dev_info(&dev->device, "Device MAC %pM link state %s",
> > rndis_device->hw_mac_adr,
> > - ((deviceInfo->link_state) ? ("down\n") : ("up\n")));
> > + ((device_info->link_state) ? ("down\n") : ("up\n")));
>
> Maybe get rid of the superfluous parentheses too?
>
> dev_info(&dev->device, "Device MAC %pM link state %s\n",
> rndis_device->hw_mac_adr,
> device_info->link_state ? "down" : "up");
>
> Also, struct rndis_device uses
> u32 link_stat;
> that is copied into struct netvsc_device_info
> bool link_state;
> could you please rationalize the names and types
> of those 2 variables?

Thanks Joe; I will get a patch out soon.

Regards,

K. Y

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥