public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Shaun Kluzek <g0del@bigpond.com>,
	gregkh@suse.de, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB GADGET: u_serial.c: fixed a brace and whitespace coding style issue
Date: Sun, 18 Sep 2011 01:26:26 -0700	[thread overview]
Message-ID: <20110918082626.GA19444@kroah.com> (raw)
In-Reply-To: <4E5F8053.4080603@ru.mvista.com>

On Thu, Sep 01, 2011 at 04:53:39PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 31-08-2011 11:22, Shaun Kluzek wrote:
> 
> >Signed-off-by: Shaun Kluzek<g0del@bigpond.com>
> >---
> >  drivers/usb/gadget/u_serial.c |    5 +----
> >  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> >diff --git a/drivers/usb/gadget/u_serial.c b/drivers/usb/gadget/u_serial.c
> >index a8aa469..b86022f 100644
> >--- a/drivers/usb/gadget/u_serial.c
> >+++ b/drivers/usb/gadget/u_serial.c
> >@@ -552,11 +552,8 @@ recycle:
> >  	/* Push from tty to ldisc; without low_latency set this is handled by
> >  	 * a workqueue, so we won't get callbacks and can hold port_lock
> >  	 */
> >-	if (tty && do_push) {
> >+	if (tty && do_push)
> >  		tty_flip_buffer_push(tty);
> >-	}
> >-
> 
>    What's wrong with the first empty line here?
> 
> >-

I agree, don't delete all of the spacing here.

greg k-h

      reply	other threads:[~2011-09-18  8:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31  7:22 [PATCH] USB GADGET: u_serial.c: fixed a brace and whitespace coding style issue Shaun Kluzek
2011-09-01 12:53 ` Sergei Shtylyov
2011-09-18  8:26   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110918082626.GA19444@kroah.com \
    --to=greg@kroah.com \
    --cc=g0del@bigpond.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sshtylyov@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox