From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756420Ab1ISPyJ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 19 Sep 2011 11:54:09 -0400
Received: from wolverine01.qualcomm.com ([199.106.114.254]:6858 "EHLO
	wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756366Ab1ISPyH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 19 Sep 2011 11:54:07 -0400
X-IronPort-AV: E=McAfee;i="5400,1158,6473"; a="119797329"
Date: Mon, 19 Sep 2011 10:54:03 -0500
From: Richard Kuo <rkuo@codeaurora.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-arch@vger.kernel.org, linux-hexagon@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 18/36] Hexagon: Add time and timer functions
Message-ID: <20110919155403.GB2627@codeaurora.org>
References: <e97c6e$3hno05@wolverine02.qualcomm.com>
 <alpine.LFD.2.02.1109191536330.2723@ionos>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LFD.2.02.1109191536330.2723@ionos>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 19, 2011 at 03:38:02PM +0200, Thomas Gleixner wrote:
> On Wed, 14 Sep 2011, Richard Kuo wrote:
> > +
> > +void debug_adsp_timers(void)
> > +{
> > +	printk(KERN_INFO "rtos_timer->match=0x%08x\n", rtos_timer->match);
> > +	printk(KERN_INFO "rtos_timer->count=%d\n", rtos_timer->count);
> > +	printk(KERN_INFO "rtos_timer->enable=%d\n", rtos_timer->enable);
> > +	printk(KERN_INFO "rtos_timer->clear=%d\n", rtos_timer->clear);
> > +}
> 
> Does this have a caller and is it useful ?
> 
> Otherwise this looks good.
> 
> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

Mostly just me being paranoid.  It can be removed.


Thanks,
Richard Kuo


-- 

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.