From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755935Ab1ISPGr (ORCPT ); Mon, 19 Sep 2011 11:06:47 -0400 Received: from moutng.kundenserver.de ([212.227.17.9]:64939 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753932Ab1ISPGq (ORCPT ); Mon, 19 Sep 2011 11:06:46 -0400 From: Arnd Bergmann To: Grant Likely Subject: Re: [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE Date: Mon, 19 Sep 2011 17:06:01 +0200 User-Agent: KMail/1.12.2 (Linux/2.6.35-22-generic; KDE/4.3.2; x86_64; ; ) Cc: Luciano Coelho , Randy Dunlap , matti.j.aaltonen@nokia.com, johannes@sipsolutions.net, linux-kernel@vger.kernel.org, sameo@linux.intel.com, mchehab@infradead.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, Jean Delvare , Tony Lindgren References: <20110829102732.03f0f05d.rdunlap@xenotime.net> <1314643307-17780-1-git-send-email-coelho@ti.com> <20110915171634.GD3523@ponder.secretlab.ca> In-Reply-To: <20110915171634.GD3523@ponder.secretlab.ca> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201109191706.01569.arnd@arndb.de> X-Provags-ID: V02:K0:BjhwWDLEFSChuhjHRNZLaztmyy7tHX7a+71M5HDOKbp pGqdvYUtE2OEBTKPQEMgKgYb1tXNH7xJfXlHTJWE31xOhpOF0y 5/WtHAIJB/RuhJafjW+SKeKI8Pp/JG1BzNiY6rrHFrwl52ax3Q wB70HJEvRkzdl40debrZPnFlxDnEp/vvzs4/rWogkCgHa2bzhd IuNzoNtdBxKI2eRiTiOAEM399O5r7DmP+P8WJ+5yqqiNbH78U2 FLdle9AXa1VJNCSoraDEATlYrBd4neNy88y5P1pnxgtPCIej2m UKwLTDKqqUsXyugsEdE+LQ2XMl8XsuQllm/QlUC5u36QGOaE3z ZU2A/jiZKb1WcptsCmv4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 15 September 2011, Grant Likely wrote: > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > index 21574bd..1836cdf 100644 > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -2,10 +2,9 @@ > > # Multifunction miscellaneous devices > > # > > > > -menuconfig MFD_SUPPORT > > - bool "Multifunction device drivers" > > +menuconfig MFD_CORE > > + tristate "Multifunction device drivers" > > depends on HAS_IOMEM > > - default y > > Looks like there is a bug here. Kconfig symbols with dependencies > (HAS_IOMEM) must not ever be selected by other symbols because Kconfig > doesn't implement a way to resolve them. This patch means that every > "select MFD_CORE" just assumes that HAS_IOMEM is also selected. That is probably a fair assumption though. Almost all architectures set HAS_IOMEM unconditionally, and the other ones (probably just s390) would not select MFD_CORE. Note that Samuel already took the other patch in the end, so it doesn't matter. The patch I posted encloses the entire directory in "if HAS_IOMEM". Arnd