From: Grant Likely <grant.likely@secretlab.ca>
To: Rob Herring <robherring2@gmail.com>
Cc: "Cousson, Benoit" <b-cousson@ti.com>,
Thomas Abraham <thomas.abraham@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"marc.zyngier@arm.com" <marc.zyngier@arm.com>,
"jamie@jamieiles.com" <jamie@jamieiles.com>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
Rob Herring <rob.herring@calxeda.com>
Subject: Re: [PATCH 5/5] ARM: gic: add OF based initialization
Date: Mon, 19 Sep 2011 14:49:48 -0600 [thread overview]
Message-ID: <20110919204948.GB30517@ponder.secretlab.ca> (raw)
In-Reply-To: <4E76615C.3000005@gmail.com>
On Sun, Sep 18, 2011 at 04:23:40PM -0500, Rob Herring wrote:
> On 09/15/2011 11:43 AM, Rob Herring wrote:
> > I see 2 options (besides leaving it as is):
> >
> > - Revert back to my previous binding where PPIs are a sub-node and a
> > different interrupt parent.
> >
> > - Use the current binding, but allow SPIs to start at 0. We can still
> > distinguish PPIs and SPIs by the cpu mask cell. A cpu mask of 0 is a
> > SPI. If there was ever a reason to have a cpu mask for an SPI, you would
> > not be able to with this scheme.
> >
> > Either way you will still have the above issue with the cell size changing.
> >
>
> I was headed down the path of implementing the 2nd option above, but had
> a dilemma. What would be the numbering base for PPIs in this case?
> Should it be 0 in the DT as proposed for SPIs or does it stay at 16?
> Numbering PPIs at 0 will just cause confusion as will numbering
> differently from SPIs. There is absolutely no mention of SPI0 or SPIx
> numbering in the GIC spec. All interrupt number references refer to the
> absolute interrupt ID, not a relative number based on the type.
Hi Rob,
See here[1] and [2] (figures 3.14 and 3.16). In both cases, there is
clearly a reference to PPI numbering from 0-15 and SPI numbering from
0-987 (as inputs to the distributor block).
[1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0416b/Bhacbfdb.html
[2] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0416b/Cihebcbg.html
g.
next prev parent reply other threads:[~2011-09-19 20:49 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 16:31 [PATCH 0/5] GIC OF bindings Rob Herring
2011-09-14 16:31 ` [PATCH 1/5] irq: add declaration of irq_domain_simple_ops to irqdomain.h Rob Herring
2011-09-14 16:31 ` [PATCH 2/5] irq: fix existing domain check in irq_domain_add Rob Herring
2011-09-14 16:44 ` Thomas Gleixner
2011-09-17 23:24 ` Grant Likely
2011-09-14 16:31 ` [PATCH 3/5] of/irq: introduce of_irq_init Rob Herring
2011-09-15 10:41 ` Arnd Bergmann
2011-09-17 23:53 ` Grant Likely
2011-09-18 1:37 ` Rob Herring
2011-09-18 6:02 ` Grant Likely
2011-09-14 16:31 ` [PATCH 4/5] ARM: gic: allow irq_start to be 0 Rob Herring
2011-09-18 6:24 ` Grant Likely
2011-09-18 12:03 ` Russell King - ARM Linux
2011-09-14 16:31 ` [PATCH 5/5] ARM: gic: add OF based initialization Rob Herring
2011-09-14 17:46 ` Marc Zyngier
2011-09-14 17:57 ` Rob Herring
2011-09-14 18:34 ` Marc Zyngier
2011-09-14 18:51 ` Rob Herring
2011-09-18 0:13 ` Grant Likely
2011-09-15 7:55 ` Thomas Abraham
2011-09-15 10:07 ` Cousson, Benoit
2011-09-15 10:29 ` Russell King - ARM Linux
2011-09-15 12:28 ` Cousson, Benoit
2011-09-15 12:51 ` Russell King - ARM Linux
2011-09-15 13:03 ` Cousson, Benoit
2011-09-15 13:11 ` Rob Herring
2011-09-15 13:52 ` Cousson, Benoit
2011-09-15 16:43 ` Rob Herring
2011-09-18 21:23 ` Rob Herring
2011-09-19 12:09 ` Cousson, Benoit
2011-09-19 13:48 ` Rob Herring
2011-09-19 14:32 ` Cousson, Benoit
2011-09-19 21:14 ` Grant Likely
2011-09-19 21:53 ` Rob Herring
2011-09-20 0:22 ` Grant Likely
2011-09-20 4:18 ` Grant Likely
2011-09-20 15:23 ` Cousson, Benoit
2011-09-19 16:00 ` Russell King - ARM Linux
2011-09-19 20:49 ` Grant Likely [this message]
2011-09-19 9:47 ` Cousson, Benoit
2011-09-19 13:33 ` Russell King - ARM Linux
2011-09-19 17:44 ` Grant Likely
2011-09-16 16:09 ` Dave Martin
2011-09-18 6:21 ` Grant Likely
2011-09-19 12:07 ` Dave Martin
2011-09-19 13:08 ` Cousson, Benoit
2011-09-18 6:15 ` Grant Likely
2011-09-19 8:47 ` Cousson, Benoit
2011-09-15 12:54 ` Rob Herring
2011-09-16 9:34 ` Thomas Abraham
2011-09-18 6:10 ` Grant Likely
2011-09-19 12:59 ` Thomas Abraham
2011-09-15 10:43 ` Arnd Bergmann
2011-09-18 6:30 ` Grant Likely
2011-09-15 8:50 ` [PATCH 0/5] GIC OF bindings Jamie Iles
2011-09-15 13:53 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110919204948.GB30517@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
--cc=shawn.guo@linaro.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).