Re: [RFC][PATCH 4/5] printk: Have wake_up_klogd() use __this_cpu_write()

Christoph Lameter
2011-09-19T21:54:59Z

On Mon, 19 Sep 2011, Steven Rostedt wrote:

> From: Steven Rostedt <srostedt@redhat.com>
>
> The wake up code that triggers klogd does not really matter which
> CPU it enables the wake up on. Every CPU will be doing a printk_tick()
> and check the current CPU. As long as one of the CPUs triggers the
> wakeup we are fine. Use __this_cpu_write() instead of this_cpu_write()
> to show that we do not care.

printk_needs_cpu() is always called from context where we have disabled
interrupts therefore this is safe to do.

Reviewed-by: Christoph Lameter <cl@gentwo.org>