linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Vasiliy Kulikov <segoon@openwall.com>,
	Balbir Singh <bsingharora@gmail.com>,
	Shailabh Nagar <nagar@us.ibm.com>,
	linux-kernel@vger.kernel.org, security@kernel.org,
	Eric Paris <eparis@redhat.com>, Stephen Wilson <wilsons@start.ca>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	David Rientjes <rientjes@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Balbir Singh <balbir@linux.vnet.ibm.com>,
	kernel-hardening@lists.openwall.com
Subject: Re: [Security] [PATCH 2/2] taskstats: restrict access to user
Date: Tue, 20 Sep 2011 08:47:37 +0300	[thread overview]
Message-ID: <20110920054736.GA2753@p183.telecom.by> (raw)
In-Reply-To: <CA+55aFzedLJfK2h2hY_a73Tn9F8Qu=LyjPhq2gVi5S=CYsCnDA@mail.gmail.com>

On Mon, Sep 19, 2011 at 10:45:20AM -0700, Linus Torvalds wrote:
> On Mon, Sep 19, 2011 at 10:39 AM, Vasiliy Kulikov <segoon@openwall.com> wrote:
> >
> > Shouldn't it simply protect taskstats_user_cmd()?  You may still poll
> > the counters with TASKSTATS_CMD_ATTR_PID/TASKSTATS_CMD_ATTR_TGID.
> 
> Yeah, I wondered where I'd really want to hook it in, that was the
> other option.
> 
> However, one thing that I'm currently independently asking some
> networking people is whether that patch guarantees anything at all: is
> the netlink command even guaranteed to be run in the same context as
> the person sending it?
> 
> After all, it comes in as a packet of data.  How synchronous is the
> genetlink thing guaranteed to be in the first place?
> 
> IOW, are *any* of those "check current capabilities/euid" approaches
> really guaranteed to be valid? Are they valid today, will they
> necessarily be valid in a year?

Netlink was made syncronous by commit cd40b7d3983c708aabe3d3008ec64ffce56d33b0
"[NET]: make netlink user -> kernel interface synchronious".

  parent reply	other threads:[~2011-09-20  5:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-24 12:09 [PATCH 2/2] taskstats: restrict access to user Vasiliy Kulikov
2011-06-29  1:27 ` Balbir Singh
2011-06-29 11:42   ` Vasiliy Kulikov
2011-06-29 20:17   ` Vasiliy Kulikov
2011-07-02  7:36     ` Vasiliy Kulikov
2011-07-04  2:57       ` Balbir Singh
2011-07-04 17:45         ` Vasiliy Kulikov
2011-07-07  8:55           ` Vasiliy Kulikov
2011-07-07 11:53             ` Balbir Singh
2011-07-07 16:23               ` Vasiliy Kulikov
2011-07-09 15:36                 ` Balbir Singh
2011-07-11 14:07                   ` Vasiliy Kulikov
2011-06-29 20:09 ` [Security] " Linus Torvalds
2011-06-30  7:57   ` Vasiliy Kulikov
2011-06-30 10:59     ` Balbir Singh
2011-06-30 12:08       ` Vasiliy Kulikov
2011-06-30 16:40       ` Linus Torvalds
2011-07-01  3:02         ` Balbir Singh
2011-09-19 16:40           ` Linus Torvalds
2011-09-19 17:20             ` Balbir Singh
2011-09-19 17:39             ` Vasiliy Kulikov
2011-09-19 17:45               ` Linus Torvalds
2011-09-20  3:35                 ` Eric W. Biederman
2011-09-20  5:47                 ` Alexey Dobriyan [this message]
2011-09-19 17:47               ` Balbir Singh
2011-09-19 18:29             ` Andi Kleen
2011-09-19 18:32               ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110920054736.GA2753@p183.telecom.by \
    --to=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=bsingharora@gmail.com \
    --cc=eparis@redhat.com \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nagar@us.ibm.com \
    --cc=rientjes@google.com \
    --cc=security@kernel.org \
    --cc=segoon@openwall.com \
    --cc=torvalds@linux-foundation.org \
    --cc=wilsons@start.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).